Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MembersTable duplicate users #2803

Merged

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Apr 23, 2024

Issue was that the page number was being manually set in the parent component, overriding the infinite query's automatic page handling.

Closes codecov/engineering-team#1637

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review April 23, 2024 19:36
@codecov-qa
Copy link

codecov-qa bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (d8586e1) to head (43c7fdb).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2803   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3382     3377    -5     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Files Coverage Δ
src/pages/MembersPage/MembersList/MembersList.jsx 100.00% <ø> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <ø> (ø)
src/services/users/useInfiniteUser.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8586e1...43c7fdb. Read the comment docs.

Copy link

codecov-public-qa bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (d8586e1) to head (43c7fdb).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2803   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3382     3316   -66     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Files Coverage Δ
src/pages/MembersPage/MembersList/MembersList.jsx 100.00% <ø> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <ø> (ø)
src/services/users/useInfiniteUser.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8586e1...43c7fdb. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2803   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         873      873           
  Lines       12634    12634           
  Branches     3358     3317   -41     
=======================================
  Hits        12439    12439           
  Misses        191      191           
  Partials        4        4           
Files Coverage Δ
src/pages/MembersPage/MembersList/MembersList.jsx 100.00% <ø> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <ø> (ø)
src/services/users/useInfiniteUser.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8586e1...43c7fdb. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 21 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.46MB 21 bytes ⬆️

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (d8586e1) to head (43c7fdb).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2803   +/-   ##
=====================================
  Coverage   98.46   98.46           
=====================================
  Files        873     873           
  Lines      12634   12634           
  Branches    3377    3316   -61     
=====================================
  Hits       12439   12439           
  Misses       191     191           
  Partials       4       4           
Files Coverage Δ
src/pages/MembersPage/MembersList/MembersList.jsx 100.00% <ø> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <ø> (ø)
src/services/users/useInfiniteUser.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.28% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8586e1...43c7fdb. Read the comment docs.

Copy link

codecov bot commented Apr 23, 2024

Bundle Report

Changes will increase total bundle size by 21 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.46MB 21 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 23, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
4649c83 Tue, 23 Apr 2024 19:47:57 GMT Expired Expired
4649c83 Tue, 23 Apr 2024 19:48:00 GMT Expired Expired
4649c83 Tue, 23 Apr 2024 19:49:22 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov merged commit 2f6e83c into main Apr 23, 2024
60 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-members-table-multiple-same-user branch April 23, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

users are duplicated when the infinite scroll (members page)
3 participants