Assortment of UI changes for coverage over time for components #2809
Conversation
| @@ -35,6 +35,50 @@ interface ComponentsTableHelper { | |||
| delete: React.ReactElement | null | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This adds the table headers (without the actual data) when in the state of either not configured, activate measurements, or is backfilling. Because we want to show the table headers and then the corresponding messages.
| @@ -382,12 +382,17 @@ export function useNavLinks() { | |||
| }, | |||
| componentsTab: { | |||
| path: ( | |||
There was a problem hiding this comment.
In the navlink to go to components tab on repo page, add an optional query param to select the initial branch to load, this is used by PR page components table where it links to the repo page components table while keeping the associated branch of them PR.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
- Coverage 98.45% 98.45% -0.01%
==========================================
Files 870 870
Lines 12632 12649 +17
Branches 3379 3327 -52
==========================================
+ Hits 12437 12453 +16
- Misses 191 192 +1
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2809 +/- ##
==========================================
- Coverage 98.45% 98.45% -0.01%
==========================================
Files 870 870
Lines 12632 12649 +17
Branches 3384 3391 +7
==========================================
+ Hits 12437 12453 +16
- Misses 191 192 +1
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2809 +/- ##
==========================================
- Coverage 98.45% 98.45% -0.01%
==========================================
Files 870 870
Lines 12632 12649 +17
Branches 3379 3386 +7
==========================================
+ Hits 12437 12453 +16
- Misses 191 192 +1
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
| @@ -94,16 +94,23 @@ export function useActivateMeasurements({ | |||
|
|
|||
There was a problem hiding this comment.
Fixes an issue where invalidateQueries was not being called correctly leading to 'BackfillComponentMemberships not being recalled.
| @@ -17,14 +17,29 @@ const DeleteComponentModal = ({ isOpen, closeModal, componentId }: Props) => { | |||
| onClose={closeModal} | |||
There was a problem hiding this comment.
This file is all text changes for the delete confirmation modal.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
========================================
- Coverage 98.46 77.22 -21.24
========================================
Files 870 864 -6
Lines 12632 12634 +2
Branches 3384 3327 -57
========================================
- Hits 12437 9756 -2681
- Misses 191 2845 +2654
- Partials 4 33 +29
... and 194 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
| @@ -125,7 +169,7 @@ function createTableData({ | |||
| /> | |||
| ), | |||
| lastUploaded: ( | |||
There was a problem hiding this comment.
align the Last Uploaded column to the left (because the values of this column are strings)
| @@ -60,8 +60,8 @@ const Header = ({ | |||
| return ( | |||
| <div className="flex flex-col justify-end divide-y divide-solid divide-ds-gray-secondary"> | |||
| <div className="grid w-2/3 divide-y divide-solid divide-ds-gray-secondary sm:w-full sm:grid-cols-2 sm:divide-x sm:divide-y-0 md:grid-cols-4"> | |||
There was a problem hiding this comment.
Fixes padding of the header area.
| @@ -97,8 +105,24 @@ const BranchSelector: React.FC = () => { | |||
| } | |||
| }} | |||
| onSearch={(term: string) => setBranchSearchTerm(term)} | |||
| disabled={isDisabled} | |||
| /> | |||
| </span> | |||
There was a problem hiding this comment.
Add the "latest commit" section under the branch selector.
| @@ -132,7 +133,17 @@ export default function ComponentsTable() { | |||
|
|
|||
| return ( | |||
| <> | |||
There was a problem hiding this comment.
Add a link to the repo's component tab with the current PR's branch
Bundle ReportChanges will increase total bundle size by 2.59kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 2.59kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
src/pages/RepoPage/ComponentsTab/BackfillBanners/SyncingBanner/SyncingBanner.tsx
Outdated
Show resolved
Hide resolved
src/pages/RepoPage/ComponentsTab/BackfillBanners/TriggerSyncBanner/TriggerSyncBanner.tsx
Outdated
Show resolved
Hide resolved
src/pages/RepoPage/ComponentsTab/Header/BranchSelector/BranchSelector.tsx
Outdated
Show resolved
Hide resolved
Description
fixes: codecov/engineering-team#1639
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.