Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag/component select 404 on flags and components tables #2816

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Apr 29, 2024

Bug was caused by trying to nullish coalesce on empty string - which is not nullish.

Closes codecov/feedback#337

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review April 29, 2024 15:06
Copy link

codecov-public-qa bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (b0bea5f) to head (114b43a).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2816   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         870      870           
  Lines       12643    12647    +4     
  Branches     3390     3331   -59     
=======================================
+ Hits        12449    12453    +4     
  Misses        190      190           
  Partials        4        4           
Files Coverage Δ
...te/ComponentsTable/hooks/useRepoComponentsTable.ts 96.77% <100.00%> (+0.22%) ⬆️
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bea5f...114b43a. Read the comment docs.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (b0bea5f) to head (114b43a).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2816   +/-   ##
=====================================
  Coverage   98.47   98.47           
=====================================
  Files        870     870           
  Lines      12643   12647    +4     
  Branches    3368    3330   -38     
=====================================
+ Hits       12449   12453    +4     
  Misses       190     190           
  Partials       4       4           
Files Coverage Δ
...te/ComponentsTable/hooks/useRepoComponentsTable.ts 96.77% <100.00%> (+0.22%) ⬆️
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bea5f...114b43a. Read the comment docs.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, discussed updating other instance but going to approve to unblock

@codecov-qa
Copy link

codecov-qa bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (b0bea5f) to head (114b43a).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2816   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         870      870           
  Lines       12643    12647    +4     
  Branches     3390     3389    -1     
=======================================
+ Hits        12449    12453    +4     
  Misses        190      190           
  Partials        4        4           
Files Coverage Δ
...te/ComponentsTable/hooks/useRepoComponentsTable.ts 96.77% <100.00%> (+0.22%) ⬆️
...Tab/subroute/FlagsTable/hooks/useRepoFlagsTable.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.56% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bea5f...114b43a. Read the comment docs.

@spalmurray-codecov spalmurray-codecov changed the title Fix flag select 404 on flags tab Fix flag/component select 404 on flags and components tables Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Bundle Report

Changes will decrease total bundle size by 30 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 6.47MB 30 bytes ⬇️

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 30 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.47MB 30 bytes ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 29, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
a13af2e Mon, 29 Apr 2024 15:22:14 GMT Expired Expired
114b43a Mon, 29 Apr 2024 15:54:35 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov merged commit 5d72a31 into main Apr 29, 2024
50 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-flags-select-404 branch April 29, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag selection leads to a 404 (not found) page
3 participants