-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flag/component select 404 on flags and components tables #2816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2816 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 870 870
Lines 12643 12647 +4
Branches 3390 3331 -59
=======================================
+ Hits 12449 12453 +4
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
=====================================
Coverage 98.47 98.47
=====================================
Files 870 870
Lines 12643 12647 +4
Branches 3368 3330 -38
=====================================
+ Hits 12449 12453 +4
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, discussed updating other instance but going to approve to unblock
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 870 870
Lines 12643 12647 +4
Branches 3390 3389 -1
=======================================
+ Hits 12449 12453 +4
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 30 bytes ⬇️
|
Bundle ReportChanges will decrease total bundle size by 30 bytes ⬇️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bug was caused by trying to nullish coalesce on empty string - which is not nullish.
Closes codecov/feedback#337