Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrick dev changes #30

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from
Draft

Patrick dev changes #30

wants to merge 41 commits into from

Conversation

McCorsa
Copy link
Collaborator

@McCorsa McCorsa commented Mar 9, 2024

No description provided.

Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for radiant-truffle-7640cb ready!

Name Link
🔨 Latest commit 4c4b314
🔍 Latest deploy log https://app.netlify.com/sites/radiant-truffle-7640cb/deploys/65ffa08395d53d00082cac87
😎 Deploy Preview https://deploy-preview-30--radiant-truffle-7640cb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@McCorsa
Copy link
Collaborator Author

McCorsa commented Mar 9, 2024

@Patadam A few issues I can see at the moment on the deploy preview:

  • Navigation items are looking quite crammed together on the top-right corner
  • The CN icon in the navbar is off-centred. I imagine this is to do with the navigation links on the right taking up more space, but I'm sure there is a workaround for this.
  • The CN icon shrinks quite dramatically when I resize the window:
    image
  • The background graphic on homepage is in an interesting position. I feel like it should somehow be anchored to the right-hand side of the screen, not the middle.

Otherwise, off to a great start with the refactoring. Keep it up!

@Patadam Patadam marked this pull request as draft June 16, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants