[BE] 회원가입 중복 확인 로그인 개인정보 조회 #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lcss 회원가입 페이지 html css
- 서버 프로젝트 생성
- 프로젝트 기반 준비하기
- Lombok Setting
- logback logging Setting
- File 로 저장하기
- SignupApplication.java 에 로깅 테스트
Add: 프론트 자원 추가
- 배포 주소 추가
[FE] 로그인, 가입하기, 아이디, 이메일, 휴대전화 중복 체크
…erest 관심사 화면 및 기능 구현
…erest Add: 데모 영상 추가
wheejuni
requested changes
Mar 29, 2020
| # After new code Injection tools there's a generated folder /iOSInjectionProject | ||
| # https://github.com/johnno1962/injectionforxcode | ||
|
|
||
| <<<<<<< HEAD |
Comment on lines
+21
to
+22
| static final String USER_ID = "userId"; | ||
| static final String PASSWORD = "password"; |
| private UserRepository userRepository; | ||
|
|
||
| @GetMapping | ||
| public Object isDuplicate(String userId, String email, String phone) { |
| throw new WrongFormatException(ErrorMessages.WRONG_FORMAT); | ||
| } | ||
|
|
||
| Optional<User> user = userRepository.findByPhoneNumber(phone); |
There was a problem hiding this comment.
단순히 전화번호 중복체크를 위해서 유저 전체를 받아오는 건 좋지 않아보이고요,
COUNT 쿼리 등을 사용하는 것으로 개선해보면 어떨까 생각이 드네요.
There was a problem hiding this comment.
|
|
||
| Optional<User> user = userRepository.findByPhoneNumber(phone); | ||
|
|
||
| if (user.isPresent()) |
| } | ||
|
|
||
| @ExceptionHandler(NotUniqueException.class) | ||
| @ResponseStatus(HttpStatus.CONFLICT) |
There was a problem hiding this comment.
CONFLICT 는 흔하게 쓰지 않는 상태코드이긴 합니다만, 클라이언트 사이드와 협의가 잘 되었다면, 크게 상관은 없겠네요.
| * Desc : userId, passwd 가 format 에 맞지 않다면 false 를 리턴합니다. | ||
| * Return : boolean | ||
| */ | ||
| public void checkValidUser() { |
There was a problem hiding this comment.
https://webcoding.tistory.com/entry/Spring-JSR-303-%EC%9C%BC%EB%A1%9C-%EA%B0%9D%EC%B2%B4-%EA%B0%92-%EA%B2%80%EC%A6%9D%ED%95%98%EA%B8%B0 참고하셔서 JSR-303 규격에 대해 한번 학습해보시고 다음부턴 적용해보세요.
| log.debug("### isValidUser()"); | ||
|
|
||
| if (!isCorrectUserIdFormat(userId)) { | ||
| log.debug("### ERROR : isCorrectUserIdFormat"); |
There was a problem hiding this comment.
그리고 유저의 입력에 따라 좌우되는 값에 대해서 ERROR 라고 로깅하는 것은 좀 어색해 보입니다.
| } | ||
|
|
||
| public static boolean isCorrectInterestFormat(String interest) { | ||
| if (interest == null) return false; |
There was a problem hiding this comment.
if문 블록이 한 줄이어도 꼭 중괄호 열어주시고, 줄바꿈 해주세요.
회원가입 기능 구현 및 컬렉션 셀 동적 사이즈 조정 기능 추가
|
수고하셨어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원가입, 개인정보조회
UserController
중복확인
로그인
API 정리 문서
https://documenter.getpostman.com/view/3004320/SzS8sk7n?version=latest