config flag to enable CORS response headers for data downloads #834
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmega
reviewed
Jun 14, 2024
| @@ -166,6 +168,12 @@ proc initDataApi(node: CodexNodeRef, repoStore: RepoStore, router: var RestRoute | |||
| Http400, | |||
| $cid.error()) | |||
|
|
|||
| if corsOrigin =? allowedOrigin: | |||
There was a problem hiding this comment.
OK for now, in the future we should probably think of a CORS config mechanism for presto so we don't have to manually set per-endpoint like this (maybe we can tackle this issue).
gmega
approved these changes
Jun 14, 2024
markspanbroek
approved these changes
Jun 17, 2024
Comment on lines
+172
to
+176
| resp.setHeader("Access-Control-Allow-Origin", corsOrigin) | ||
| resp.setHeader("Access-Control-Allow-Methods", "GET, OPTIONS") | ||
| resp.setHeader("Access-Control-Headers", "X-Requested-With") | ||
| resp.setHeader("Access-Control-Max-Age", "86400") | ||
|
|
There was a problem hiding this comment.
This is repeated twice, can we extract this to a proc, or a template?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when downloading data from a browser, eg the ethcc-demo