Reduce hardcoded strings, fix windows test

Signed-off-by: Luca Della Vedova <[email protected]>

test/rust-sample-package/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "rust-sample-app"
+name = "rust-sample-package"
 version = "0.1.0"
 authors = ["Nikos Koukis <[email protected]>"]
 edition = "2018"

test/test_build.py

@@ -2,6 +2,7 @@
 # Licensed under the Apache License, Version 2.0
 
 import asyncio
+import os
 from pathlib import Path
 import shutil
 import tempfile
@@ -15,7 +16,9 @@
 from colcon_core.task import TaskContext
 import pytest
 
-test_project_path = Path(__file__).parent / 'rust-sample-package'
+TEST_PACKAGE_NAME = 'rust-sample-package'
+
+test_project_path = Path(__file__).parent / TEST_PACKAGE_NAME
 
 
 @pytest.fixture(autouse=True)
@@ -33,7 +36,7 @@ def test_package_identification():
     desc = PackageDescriptor(test_project_path)
     cpi.identify(desc)
     assert desc.type == 'cargo'
-    assert desc.name == 'rust-sample-app'
+    assert desc.name == TEST_PACKAGE_NAME
 
 
 @pytest.mark.skipif(
@@ -75,6 +78,10 @@ def test_build_package():
 
             # Make sure the binary is compiled
             install_base = Path(task.context.args.install_base)
-            assert (install_base / 'bin' / 'rust-sample-app').is_file()
+            app_name = TEST_PACKAGE_NAME
+            # Executable in windows have a .exe extension
+            if os.name == 'nt':
+                app_name += '.exe'
+            assert (install_base / 'bin' / app_name).is_file()
     finally:
         event_loop.close()