Collect crate metadata during 'prepare' phase of build #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cottsay
commented
Dec 23, 2024
cottsay
commented
- If metadata collection fails for some reason, it would be good if we hadn't already performed any operations on the package.
- It would be good to have the metadata earlier in the process so we can use it in other operations.
* If metadata collection fails for some reason, it would be good if we hadn't already performed any operations on the package. * It would be good to have the metadata earlier in the process so we can use it in other operations.
cottsay
force-pushed
the
cottsay/collect-metadata-early
branch
from
c56a200 to
9f0da9b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 68.07% 68.44% +0.36%
==========================================
Files 7 7
Lines 260 263 +3
Branches 44 44
==========================================
+ Hits 177 180 +3
Misses 55 55
Partials 28 28 ☔ View full report in Codecov by Sentry. |
luca-della-vedova
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.