Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for path dependency #53

Merged

Conversation

luca-della-vedova
Copy link
Member

Turns out it's just one line since we already have two packages

Signed-off-by: Luca Della Vedova <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (9f1da80) to head (bcb5722).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           cottsay/dep-source-info      #53      +/-   ##
===========================================================
+ Coverage                    66.79%   68.28%   +1.49%     
===========================================================
  Files                            7        7              
  Lines                          268      268              
  Branches                        46       46              
===========================================================
+ Hits                           179      183       +4     
+ Misses                          60       56       -4     
  Partials                        29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luca-della-vedova luca-della-vedova marked this pull request as draft December 24, 2024 02:35
@luca-della-vedova luca-della-vedova marked this pull request as ready for review December 24, 2024 05:23
@luca-della-vedova
Copy link
Member Author

Sadly the test became fairly convoluted because we need to support old Python versions, but at least now we can make sure path resolution works

@luca-della-vedova luca-della-vedova merged commit 94d99e5 into cottsay/dep-source-info Dec 24, 2024
17 checks passed
@luca-della-vedova luca-della-vedova deleted the luca/relative_dependency_test branch December 24, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants