Move _PyObject_SetDeferredRefcount call up

colesbury · Jan 10, 2025 · a0bcabc · a0bcabc
1 parent a8c2e44
commit a0bcabc
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
@@ -1414,6 +1414,10 @@ local_new(PyTypeObject *type, PyObject *args, PyObject *kw)
         return NULL;
     }
 
+    // gh-128691: Use deferred reference counting for thread-locals to avoid
+    // contention on the shared object.
+    _PyObject_SetDeferredRefcount((PyObject *)self);
+
     self->args = Py_XNewRef(args);
     self->kw = Py_XNewRef(kw);
 
@@ -1435,7 +1439,6 @@ local_new(PyTypeObject *type, PyObject *args, PyObject *kw)
     Py_DECREF(localsdict);
     Py_DECREF(sentinel_wr);
 
-    _PyObject_SetDeferredRefcount((PyObject *)self);
     return (PyObject *)self;
 
   err: