-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of portaudio/19.7.0 and fix for vulkan-loader/1.3.239.0 for conan 2.0 #16414
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
Sorry but it is not allowed to change 2 recipes in the same PR. Moreover there is already a PR fixing vulkan-loader recipe for conan v2: #16232 |
Sorry @spacelm, I have just realised how you have addressed the VS issue in your vulkan-loader pull request. I hadn't found your correction for that particular bit before. And about portaudio I didn't have much hope that my version would be accepted after discussing with @Croydon anyway so I am withdrawing this whole pull request. |
There are two items in this pull request:
Introduction of the portaudio/19.7.0 recipe for conan 2.x
fixes #16335
Following our discussion with @Croydon on #16335 I have made the following further modifications to it:
Minor fix for the vulkan-loader/1.3.239.0 package for conan 2.x
fixes #16358
I understand that this pull request may be rejected, based on past discussions, but I thought to submit my potential contributions anyway, in case they prove useful either by integration into the cci repository, or at least as information that can be used in improvements implemented by others.