Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of portaudio/19.7.0 and fix for vulkan-loader/1.3.239.0 for conan 2.0 #16414

Closed
wants to merge 11 commits into from

Conversation

dimi309
Copy link

@dimi309 dimi309 commented Mar 7, 2023

There are two items in this pull request:

Introduction of the portaudio/19.7.0 recipe for conan 2.x
fixes #16335
Following our discussion with @Croydon on #16335 I have made the following further modifications to it:

  • I have restored the default options the recipe had on bincrafters (both alsa and jack options are now set to true by default)
  • Since I have not managed to get the conancenter's libalsa package to produce sound on linux since 2021 (please see [package] libalsa/1.1.9 & libalsa/1.2.5.1: No devices listed via portaudio #7526) and I have not been able to fix it myself, I have removed the "hacky" option I had originally implemented to allow its use from this portaudio package (please also see Portaudio 19.7.0 fixes: invalid device error and mingw gcc build bincrafters/community#1419) and have completely removed the libalsa conancenter requirement from portaudio. The portaudio package now uses the linux system alsa package now (installed by apt or yum). I understand that this is less than ideal but please note that the conancenter libalsa problem has been around for a long time, not allowing the portaudio package to ever produce sound on Linux, at least on my end whenever I have tried to use it. The solution in this pull request has allowed me to use the portaudio package (this variation I am submitting originally copied from bincrafters), playing sound on Linux on many machines without issue. It might be worth adding it to conancenter as is, so that others can also benefit from it. (I would not mind making other improvements to the recipe though, appart from re-adding conancenter's alsa requirement)

Minor fix for the vulkan-loader/1.3.239.0 package for conan 2.x
fixes #16358

I understand that this pull request may be rejected, based on past discussions, but I thought to submit my potential contributions anyway, in case they prove useful either by integration into the cci repository, or at least as information that can be used in improvements implemented by others.


@CLAassistant
Copy link

CLAassistant commented Mar 7, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 7, 2023

Sorry but it is not allowed to change 2 recipes in the same PR.

Moreover there is already a PR fixing vulkan-loader recipe for conan v2: #16232

@dimi309
Copy link
Author

dimi309 commented Mar 7, 2023

Sorry but it is not allowed to change 2 recipes in the same PR.

Moreover there is already a PR fixing vulkan-loader recipe for conan v2: #16232

Sorry @spacelm, I have just realised how you have addressed the VS issue in your vulkan-loader pull request. I hadn't found your correction for that particular bit before. And about portaudio I didn't have much hope that my version would be accepted after discussing with @Croydon anyway so I am withdrawing this whole pull request.

@dimi309 dimi309 closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants