zxing: include path #26361
Open
zxing: include path #26361
+66
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Official pkgConfig for ZXing add ZXing/ to include path. https://github.com/zxing-cpp/zxing-cpp/blob/master/core/zxing.pc.in
See zxing-cpp/zxing-cpp@53da586 Fixed in zxing-cpp >= 1.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: zxing/2.3.0
Motivation
Have application build with
gcc $(pkg-config --cflags --libs zxing)compatible with conan package zxing.Details
This essentially revert 5593391. Not having the proper include paths when using conan packages forces the use of patches for application that relies on zxing, ex: gstreamer pull request
Official pkgConfig for ZXing add ZXing/ to include path.
This makes conan package behave the same as official package.
bonus: add gcc >=13 support for old package.