-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libdeflate: relocatable shared lib on macOS #9089
libdeflate: relocatable shared lib on macOS #9089
Conversation
This comment has been minimized.
This comment has been minimized.
avoid error "Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being set."
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You've been bitten by something we haven't considered regarding the epochs 😞 If your read through my post of one of the latest library updates, now we are using epochs to decide the configurations that we can run for a given package, one library cannot jump to a new epoch (more configs) until all its requirements have already jumped to it. ...but we use only the requirements of the main conanfile, not the ones in The problem is that there is no Conan command that will expand the graph of the test-package as well, so we don't know those dependencies until we actually run it. So far, I can think about these alternatives:
I'll talk to @danimtb about it and see if we can figure out something else. |
# Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being | ||
# set. This could be because you are using a Mac OS X version less than 10.5 | ||
# or because CMake's platform configuration is corrupt. | ||
# FIXME: Remove once CMake on macOS/M1 CI runners is upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MacOS runners are using CMake 3.15 following the requirement here: https://github.com/conan-io/tribe/blob/main/design/004-tools-cmake.md. If it is not enough, it's not going to be upgraded because of that restriction.
We can have a look to the other reasons you mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the trick from another recipe actually. I guess it's a bug in CMake with relocatable shared libs on macos M1, fixed recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this temporary workaround, it's more or less explained in #7146
it's a CMake bug that was fixed only in 3.20.1+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed: #7146 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's amazing the number of details you manage to keep in your head 😊 .
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The underlying issue with the requirements from the |
see conan-io/hooks#376
conan-center hook activated.