Skip to content

Commit

Permalink
Merge pull request #2293 from conda-forge/beckermr-patch-1
Browse files Browse the repository at this point in the history
doc: update output validation changes
  • Loading branch information
beckermr authored Sep 10, 2024
2 parents 133ae53 + aa88e20 commit 14ac9ba
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions docs/maintainer/infrastructure.md
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ the following things:
- Rerender the feedstock in a PR from a fork of the feedstock and merge.
- Request a feedstock token reset via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#reset-your-feedstock-token).
- Request that any new packages be added to the allowed outputs for the feedstock
via our [admin-requests-repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).
via our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).

New packages that are added to existing feedstocks are not registered automatically in order to prevent
typo squatting and other malicious activities. Package outputs are added during feedstock creation.
Expand All @@ -652,8 +652,9 @@ you will need to request that the new package name be added to your feedstock vi
[admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).

In rare cases, the package name may change regularly in a well-defined way (e.g., `libllvm18`, `libllvm19`, etc.).
In this case, please submit a PR updating our [list of feedstocks with allowed glob patterns](https://github.com/conda-forge/feedstock-outputs/blob/main/feedstock_outputs_autoreg_allowlist.yml). Output packages that match
these patterns will be automatically registered for your feedstock.
In this case, you can use our [admin-requests repo](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock)
to add a glob pattern that matches the new package name pattern. We use the Python `fnmatch` module syntax.
Output packages that match these patterns will be automatically registered for your feedstock.

## Stages of package building and involved infrastructure

Expand Down
6 changes: 3 additions & 3 deletions news/2024-09-08-output-validation-changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ adding new packages to existing feedstocks (e.g., when a new output is added), w
require that maintainers submit a PR to add the new output via our
[admin-requests repository](https://github.com/conda-forge/admin-requests?tab=readme-ov-file#add-a-package-output-to-a-feedstock).
New feedstocks created via `staged-recipes` will have their outputs added automatically. If you maintain a feedstock
that regularly adds new outputs (e.g., `llvmdev` has `libllvm18`, `libllvm19`, etc.), we have created a
[list of feedstocks with allowed glob patterns](https://github.com/conda-forge/feedstock-outputs/blob/main/feedstock_outputs_autoreg_allowlist.yml). These feedstocks will have any outputs matching their glob patterns
added automatically. If you would like to add your feedstock to this list, please submit a PR. Further
that regularly adds new outputs (e.g., `llvmdev` has `libllvm18`, `libllvm19`, etc.), you can use the `admin-requsts` repo
to add a glob pattern that matches the pattern of your new outputs. We test these patterns aginst new outputs from the feedstock
using the Python `fnmatch` module. Outputs from the feedstock that match a glob pattern will added automatically. Further
details on package output validation can be found in our [documentation](https://conda-forge.org/docs/maintainer/infrastructure/#output-validation-and-feedstock-tokens).

0 comments on commit 14ac9ba

Please sign in to comment.