-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL #117
base: main
Are you sure you want to change the base?
Fix URL #117
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12834119108. Examine the logs at this URL for more detail. |
@conda-forge/core - we're trying to figure out why the bot changed the download URL in 60e106c? Is the change proposed in this PR going against best practices? |
@@ -8,11 +8,11 @@ package: | |||
version: {{ version }} | |||
|
|||
source: | |||
url: https://files.pythonhosted.org/packages/8c/40/096ceb30b86ea829031662dfcd1d3014a7e1634aff2bc72f3680c97e084c/zarr-{{ version }}.tar.gz | |||
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | |
url: https://pypi.org/packages/source/z/zarr/zarr-{{ version }}.tar.gz |
Honestly, I find that {{ name }} is simply unreadable, this is a "simple" url that is meant to be human readable. the example in the staged recipes is designed to be "easily changed" so that the name defines everything, but for ongoing maintainability, just keep it simple.
same goes for the {{ name | lower }}
I believe we had some issues with the bot in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same goes for the {{ name | lower }}
I just can't leave a comment so high up.
@@ -8,11 +8,11 @@ package: | |||
version: {{ version }} | |||
|
|||
source: | |||
url: https://files.pythonhosted.org/packages/8c/40/096ceb30b86ea829031662dfcd1d3014a7e1634aff2bc72f3680c97e084c/zarr-{{ version }}.tar.gz | |||
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | |||
sha256: {{ sha256 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sha256: {{ sha256 }} | |
sha256: 033859c5603dc9c29e53af494ede24b42f1b761d2bb625466990a3b8a9afb792 |
There is also virtually no reason not to copy the sha256
in there it is a variable that never gets reused.
I think it was just a bug. feel free to ignore my other suggestions. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #115