Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix URL #117

wants to merge 1 commit into from

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jan 17, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #115

@jhamman
Copy link
Member Author

jhamman commented Jan 17, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12834119108. Examine the logs at this URL for more detail.

@dstansby
Copy link
Contributor

Hmm, it was a bot that orginally updated the URL to this format (60e106c), so it would be good to understand why it did that, if it was a mistake, and if it wasn't, why #115 didn't work

@jhamman
Copy link
Member Author

jhamman commented Jan 17, 2025

@wolfv - do you have ideas why the bot would have changed this in a prior bump but not in #115?

@jhamman
Copy link
Member Author

jhamman commented Jan 20, 2025

@conda-forge/core - we're trying to figure out why the bot changed the download URL in 60e106c? Is the change proposed in this PR going against best practices?

@@ -8,11 +8,11 @@ package:
version: {{ version }}

source:
url: https://files.pythonhosted.org/packages/8c/40/096ceb30b86ea829031662dfcd1d3014a7e1634aff2bc72f3680c97e084c/zarr-{{ version }}.tar.gz
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
url: https://pypi.org/packages/source/z/zarr/zarr-{{ version }}.tar.gz

Honestly, I find that {{ name }} is simply unreadable, this is a "simple" url that is meant to be human readable. the example in the staged recipes is designed to be "easily changed" so that the name defines everything, but for ongoing maintainability, just keep it simple.

same goes for the {{ name | lower }}

I believe we had some issues with the bot in the past.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same goes for the {{ name | lower }}

I just can't leave a comment so high up.

@@ -8,11 +8,11 @@ package:
version: {{ version }}

source:
url: https://files.pythonhosted.org/packages/8c/40/096ceb30b86ea829031662dfcd1d3014a7e1634aff2bc72f3680c97e084c/zarr-{{ version }}.tar.gz
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: {{ sha256 }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256: {{ sha256 }}
sha256: 033859c5603dc9c29e53af494ede24b42f1b761d2bb625466990a3b8a9afb792

There is also virtually no reason not to copy the sha256 in there it is a variable that never gets reused.

@hmaarrfk
Copy link

@conda-forge/core - we're trying to figure out why the bot changed the download URL in 60e106c? Is the change proposed in this PR going against best practices?

I think it was just a bug.

feel free to ignore my other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants