Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extendLease as task_router param #213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added extendLease as task_router param #213

wants to merge 2 commits into from

Conversation

shalindeval
Copy link

@shalindeval shalindeval commented Sep 30, 2023 •
edited
Loading

  • The task with extendLease set to True won't be rescheduled by the Conductor unless it gets timed out with RETRY set as timeoutPolicy.

Note: The feature is already implemented on the Conductor core and Java client. Just the task_router needs to be updated on Python's client side.

Discussion ref: Netflix/conductor#1378

@shalindeval
Copy link
Author

@v1r3n Could you please review it?

@coderabhigupta coderabhigupta self-requested a review November 6, 2023 02:22
@coderabhigupta coderabhigupta requested review from c4lm and v1r3n November 14, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamsngh shivamsngh shivamsngh approved these changes

@coderabhigupta coderabhigupta Awaiting requested review from coderabhigupta

@c4lm c4lm Awaiting requested review from c4lm

@v1r3n v1r3n Awaiting requested review from v1r3n

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shalindeval @shivamsngh