Skip to content

Commit

Permalink
feat(deployment): allow existing service account usage
Browse files Browse the repository at this point in the history
  • Loading branch information
pchanvallon committed Aug 21, 2024
1 parent 9b059b7 commit a32c50b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/gateway/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: "3.2.1"
description: Conduktor Gateway chart
name: conduktor-gateway
version: 3.2.1
version: 3.2.2
dependencies:
- name: kafka
repository: https://charts.bitnami.com/bitnami
Expand Down
4 changes: 1 addition & 3 deletions charts/gateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ helm install myGateway conduktor/conduktor-gateway

This section contains configuration of the gateway


### Conduktor-gateway image configuration

This section define the image to be used
Expand Down Expand Up @@ -61,7 +60,6 @@ This section is for configuring gateway to handle certificate to manage SSL endp

This section contains kubernetes services configuration


### Conduktor-gateway external service configurations

This section specify external service configuration
Expand Down Expand Up @@ -106,6 +104,7 @@ Shared kubernetes configuration of the chart
| Name | Description | Value |
| ----------------------- | -------------------------------------------------------------- | ------- |
| `serviceAccount.create` | Create Kubernetes service account. Default kube value if false | `false` |
| `serviceAccount.name` | Service account name to attach to the Gateway deployment | `""` |
| `commonLabels` | Labels to be applied to all ressources created by this chart | `{}` |
| `nodeSelector` | Container node selector | `{}` |
| `tolerations` | Container tolerations | `[]` |
Expand All @@ -118,4 +117,3 @@ Enable and configure chart dependencies if not available in your deployment
| Name | Description | Value |
| --------------- | ----------------------------------------------------------------------------- | ------- |
| `kafka.enabled` | Deploy a kafka along side gateway (This should only used for testing purpose) | `false` |

2 changes: 0 additions & 2 deletions charts/gateway/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,7 @@ spec:
items:
- key: interceptors.json
path: interceptors.json
{{- if .Values.serviceAccount.create }}
serviceAccountName: {{ template "conduktor-gateway.serviceAccountName" . }}
{{- end }}
{{- with .Values.global.imagePullSecrets }}
imagePullSecrets: {{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/gateway/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ serviceAccount:
# Specifies whether a service account should be created
# If AWS IAM is used, need to have create: false
create: false
## @param serviceAccount.name Service account name to attach to the Gateway deployment
name: ""

## @param commonLabels Labels to be applied to all ressources created by this chart
commonLabels: {}
Expand Down

0 comments on commit a32c50b

Please sign in to comment.