Add example configs to connect to Confluent Cloud #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophschubert
commented
Aug 22, 2024
christophschubert
commented
- Add example config to connect Console to Confluent Cloud
- Add example config to connect Gateway to Confluent Cloud
- Add links to documentation to GW-chart README
- Try to make punctuation more consistent
- Add example config to connect Console to Confluent Cloud - Add example config to connect Gateway to Confluent Cloud - Add links to documentation to GW-chart README - Try to make punctuation more consistent
qboileau
reviewed
Aug 22, 2024
There was a problem hiding this comment.
You also need to update comments in values to match what you want on the README files. We are using https://github.com/bitnami/readme-generator-for-helm to re-generate the README from values comments.
(I will put a make target to simplify this)
qboileau
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.