Allow multiple calls to SetStatisticsHandler / SetLogHandler / SetErrorHandler #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g7ed6e
force-pushed
the
feature/multiple-calls-to-set-xxx-handler
branch
from
cf970f9 to
254ccfc
Compare
g7ed6e
changed the title
|
@forlack: This PR would be useful for dotnet/aspire#951 and open-telemetry/opentelemetry-dotnet-contrib#1493. Please see details in related issue #2154 |
eerhardt
reviewed
Dec 14, 2023
g7ed6e
force-pushed
the
feature/multiple-calls-to-set-xxx-handler
branch
2 times, most recently
from
2694696 to
00a8164
Compare
eerhardt
reviewed
Jan 5, 2024
| LogToFile("end ConsumerBuilder_SetStatisticsHandler"); | ||
| } | ||
|
|
||
| [SkipWhenCITheory("Requires to stop the broker in the while loop to simulate broker is down."), MemberData(nameof(KafkaParameters))] |
There was a problem hiding this comment.
I'm not sure I understand. This requires someone to manually stop the broker?
There was a problem hiding this comment.
Exactly. this is required during the unit test to get the error handler called.
| var record = consumer.Consume(TimeSpan.FromMilliseconds(100)); | ||
| if (record == null) { continue; } | ||
| if (record.IsPartitionEOF) { break; } | ||
| msgCnt += 1; |
There was a problem hiding this comment.
Do you want to assert how many messages were counted?
There was a problem hiding this comment.
No that's not required here. good catch, I dropped the useless msgCnt variables.
g7ed6e
force-pushed
the
feature/multiple-calls-to-set-xxx-handler
branch
from
6e1e71e to
e5552df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2154