Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/packaging/bootc.spec: sync with current Fedora rawhide #1026

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jmarrero
Copy link
Member

No description provided.

@jmarrero
Copy link
Member Author

mmm I think the rpm-build still can't deal with auto release let's see how the build goes.

@jmarrero jmarrero closed this Jan 14, 2025
@jmarrero
Copy link
Member Author

seems stream 9/rhel9 needs us to be conservative here.

@cgwalters
Copy link
Collaborator

Wait what was broken?

@jmarrero
Copy link
Member Author

jmarrero commented Jan 14, 2025

The rpms for c9s. -f is not found by cargo, trying with --features to see if it's enough here.

@jmarrero jmarrero reopened this Jan 14, 2025
@jmarrero jmarrero force-pushed the spec-update branch 2 times, most recently from b477137 to 75d78e0 Compare January 14, 2025 20:58
@cgwalters
Copy link
Collaborator

In c10s:

cargo_build: invalid option -- '-'
error: /builddir/build/originals/bootc.spec: line 71: Unknown option - in cargo_build(naf:)
  1<    (%)
  0<  (%cargo_build)

Offhand...I think the rust-toolset in rhel10 is too old? I think it supports -f but not --features?

@cgwalters
Copy link
Collaborator

Ok and c9s died on

thread 'lints::tests::test_baseimage_root' panicked at lib/src/lints.rs:300:64:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Hmm...ummm, I guess because something in the RPM build path is overriding the cargo stuff and we're missing CARGO_MANIFEST_PATH ?

What a mess

@cgwalters
Copy link
Collaborator

Can you merge in

From 8388662ce6086e40c63e8774d2568402a3055660 Mon Sep 17 00:00:00 2001
From: Colin Walters <[email protected]>
Date: Tue, 14 Jan 2025 16:58:53 -0500
Subject: [PATCH] tests: Ignore baseimage root test if CARGO_MANIFEST_PATH is
 not set

This is only in relatively new Rust (not in RHEL 9.5).

Signed-off-by: Colin Walters <[email protected]>
---
 lib/src/lints.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/src/lints.rs b/lib/src/lints.rs
index 9c0942cb..d382e8e4 100644
--- a/lib/src/lints.rs
+++ b/lib/src/lints.rs
@@ -297,7 +297,10 @@ mod tests {
         assert!(check_baseimage_root(&td).is_err());
 
         // Copy our reference base image content from the source dir
-        let manifest = std::env::var_os("CARGO_MANIFEST_PATH").unwrap();
+        let Some(manifest) = std::env::var_os("CARGO_MANIFEST_PATH") else {
+            // This was only added in relatively recent cargo
+            return Ok(());
+        };
         let srcdir = Path::new(&manifest)
             .parent()
             .unwrap()
-- 
2.47.0

I think we don't need to backport that downstream because we don't need to care about the unit tests on older rust (in rhel).

jmarrero and others added 2 commits January 14, 2025 17:08
This is only in relatively new Rust (not in RHEL 9.5).

Signed-off-by: Colin Walters <[email protected]>
Signed-off-by: Joseph Marrero Corchado <[email protected]>
@cgwalters cgwalters merged commit 04332ca into containers:main Jan 14, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants