install: Add kargs to installation config
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
force-pushed
the
kargs-install
branch
from
536bd04 to
7fe3bff
Compare
|
Pairs with CentOS/centos-bootc-layered#6 |
cgwalters
force-pushed
the
kargs-install
branch
from
7fe3bff to
687798a
Compare
|
OK, tested this and it works! |
cgwalters
force-pushed
the
kargs-install
branch
from
687798a to
c96c2e7
Compare
|
/retest |
cgwalters
force-pushed
the
kargs-install
branch
5 times, most recently
from
8c86589 to
5e64d34
Compare
Out of general principle, since we're adding new ones. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
kargs-install
branch
4 times, most recently
from
cee380e to
d7d4235
Compare
We know we eventually want "day 2" management of kargs, but supporting "install time" kargs in a somewhat container-native way will let us more properly set up things like the `console=` karg only for cloud images for example. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
kargs-install
branch
from
d7d4235 to
9ba17af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know we eventually want "day 2" management of kargs, but supporting "install time" kargs in a somewhat container-native way will let us more properly set up things like the
console=karg only for cloud images for example.