install: Generalize root-fs-type into install.filesystem.root.type
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
jeckersb
requested changes
Jan 29, 2024
cgwalters
force-pushed
the
generalize-install-config
branch
from
c9ff696 to
cf00487
Compare
Keep (but soft-deprecate) the existing `root-fs-type`, and add a more general set of tables in `install.filesystem.root`, with `type` as a field underneath that. This somewhat resembles the [Image Builder blueprint](https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html/composing_a_customized_rhel_system_image/creating-system-images-with-composer-command-line-interface_composing-a-customized-rhel-system-image#composer-blueprint-format_creating-system-images-with-composer-command-line-interface) design. In particular, this aims to leave space for containers#287 where we'd add e.g. ``` [install.filesystem.root] extra = "5G" ``` for size specification. Another obvious extension would be `options` to pass through options to `mkfs.$fs`; not clear to me we totally want to go there, but we clearly need something a bit more general. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
generalize-install-config
branch
from
cf00487 to
558cd4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep (but soft-deprecate) the existing
root-fs-type, and add a more general set of tables ininstall.filesystem.root, withtypeas a field underneath that.This somewhat resembles the Image Builder blueprint design.
In particular, this aims to leave space for
#287
where we'd add e.g.
for size specification.
Another obvious extension would be
optionsto pass through options tomkfs.$fs; not clear to me we totally want to go there, but we clearly need something a bit more general.