New feature added: Integrated WebView with Native Speech and PiperTTS #3695
Conversation
✅ Deploy Preview for continuedev canceled.
|
There was a problem hiding this comment.
The useWebviewListener("setTTSNative") handler's mixed return types (true, false, or a Promise) can cause inconsistent behavior, making it harder to handle. Standardizing the return type to always be a Promise or whatever is ideal ensures predictability and simplifies integration, reducing potential bugs and improving maintainability.
The Promise in setTTSNative lacks explicit error handling, which could result in uncaught errors during unexpected failures. Try wrapping the logic in a try-catch block to ensure errors are logged and handled.
There was a problem hiding this comment.
The
useWebviewListener("setTTSNative")handler's mixed return types (true,false, or aPromise) can cause inconsistent behavior, making it harder to handle. Standardizing the return type to always be aPromiseor whatever is ideal ensures predictability and simplifies integration, reducing potential bugs and improving maintainability.The
PromiseinsetTTSNativelacks explicit error handling, which could result in uncaught errors during unexpected failures. Try wrapping the logic in atry-catchblock to ensure errors are logged and handled.
setTTSNative:[{lang:string, message:string}, boolean];
In the code above, the return value is defined only as boolean, and there isn't Promise return type.
Since only the event is defined within the Promise, any error will only affect the event and will not impact the Promise
Description
Checklist
Config
You can get the voice list from this link.
Fixed
Resolved issue with stopping audio playback #2311
Issue
Usage of worker within WebView only accepts blob URLs. As a temporary solution, a worker has been defined. Vite can't detect the web worker with blobURL, and this issue needs to be resolved.