Nate/platform #3724
Open
Nate/platform #3724
+1,955
−321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: I don't believe this requires any new tests. The changes are either a) refactors of very core behavior (which means that it will be tested multiple times over by each of our end-to-end tests, something would be obviously wrong) or b) isolated new behavior that is only introduced after adding the hidden
.use_platformfile or aconfig.yaml, both of which are in such an early phase of feedback gathering that postponing to add tests whose behavior is likely to change after we try them doesn't make sense.The primary area that has a chance of being affected is Continue for Teams, but this has been tested manually and any tests would very quickly become irrelevant given plans.
I have also been testing this locally myself for more than a week without seeing any regressions.
Otherwise there's the chance that somehow we falsely think that the user is in internal platform mode. I have tested this with every combination of .use_platform and launch.json, so am pretty confident this works. Again it would be a test that would be thrown out