-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start of work to refactor submit #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submit now uses the flux operator python sdk (non released version) to create / submit / delete the minicluster, no need for external scripts except for starting minikube. This is likely an improvement and I am going to also test using the sdk for apply. Signed-off-by: vsoch <[email protected]>
I still need to save the nodes/pods and other cluster info to the .scripts directory, but the basic apply is now working JUST using the Python SDK. When this is all done, we should be able to remove the custom scripts that are running jobs, and update and test all the cloud examples. Signed-off-by: vsoch <[email protected]>
everything should now use the python sdk Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
18th time is the charm! I'm going to do a full run through on google cloud after dinner - if that is good (minus being able to test fully on aws) we should be good to merge and release (and move forward from there). |
Signed-off-by: vsoch <[email protected]>
Note that the operator needs to be deployed with the changes before flux-cloud can use them here. |
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
The test_examples.py should probably be split up! |
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit now uses the flux operator python sdk (non released version) to create / submit / delete the minicluster, no need for external scripts except for starting minikube. This is likely an improvement and I am going to also test using the sdk for apply.
TODO:
flux experiments init
command and tutorial to show using it (it's too hard to create atm)