Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of work to refactor submit #28

Merged
merged 25 commits into from
Mar 6, 2023
Merged

start of work to refactor submit #28

merged 25 commits into from
Mar 6, 2023

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Mar 3, 2023

Submit now uses the flux operator python sdk (non released version) to create / submit / delete the minicluster, no need for external scripts except for starting minikube. This is likely an improvement and I am going to also test using the sdk for apply.

TODO:

vsoch added 18 commits March 2, 2023 19:38
submit now uses the flux operator python sdk (non released version) to
create / submit / delete the minicluster, no need for external scripts
except for starting minikube. This is likely an improvement and I am going
to also test using the sdk for apply.

Signed-off-by: vsoch <[email protected]>
I still need to save the nodes/pods and other cluster info to
the .scripts directory, but the basic apply is now working JUST
using the Python SDK. When this is all done, we should be able
to remove the custom scripts that are running jobs, and update
and test all the cloud examples.

Signed-off-by: vsoch <[email protected]>
everything should now use the python sdk

Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
@vsoch
Copy link
Member Author

vsoch commented Mar 4, 2023

18th time is the charm! I'm going to do a full run through on google cloud after dinner - if that is good (minus being able to test fully on aws) we should be good to merge and release (and move forward from there).

@vsoch
Copy link
Member Author

vsoch commented Mar 5, 2023

Note that the operator needs to be deployed with the changes before flux-cloud can use them here.

@vsoch
Copy link
Member Author

vsoch commented Mar 6, 2023

The test_examples.py should probably be split up!

@vsoch vsoch merged commit 97f2777 into main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant