Fix rpm-ostree to handle ostree semver-incompatible changes #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
RishabhSaini
force-pushed
the
override
branch
2 times, most recently
from
9fbb835 to
d674b1b
Compare
RishabhSaini
changed the title
RishabhSaini
changed the title
cgwalters
reviewed
May 9, 2023
There was a problem hiding this comment.
Nice! Thanks so much for doing this! Looks good to me.
So at a technical level right now this blocks on an "official" release of the new ostree-ext crate, which in turn needs to wait until your changes in ostreedev/ostree-rs-ext#456 land at least.
(We may also want to go over the API and see if there are any other possible cleanups)
|
OK several other changes happened in ostree-ext git main since then, so I've reworked this to match! |
This was referenced May 10, 2023
- ostree-ext updates to new ostree, so adjust our usage of the ostree crate - Also adjust for changed ostree-ext APIs - ostree-ext now re-exports cap-std-ext 2.0, which stopped re-exporting rustix, so depend on that directly
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
May 21, 2023
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
May 21, 2023
This is similar to coreos/rpm-ostree#4400 Signed-off-by: Colin Walters <[email protected]>
|
We ended up keeping this rolled into #4271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo: Override to the main branch of ostree-rs-ext
Fixing ostree semver-incompatible changes