Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update minimize dtype for int64 & int8 support #159

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 added the bug Something isn't working label Jan 16, 2024
@snowman2 snowman2 added this to the 0.4.2 milestone Jan 16, 2024
@snowman2 snowman2 requested a review from alfredoahds January 16, 2024 20:11
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdb953d) 97.24% compared to head (d59889d) 97.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   97.24%   97.02%   -0.23%     
==========================================
  Files          14       14              
  Lines         436      437       +1     
==========================================
  Hits          424      424              
- Misses         12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alfredoahds alfredoahds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@snowman2 snowman2 merged commit d39758e into master Jan 16, 2024
17 checks passed
@snowman2 snowman2 deleted the minimize_dtype branch January 16, 2024 20:34
@snowman2
Copy link
Member Author

Thanks @alfredoahds 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Update minimize dtype for int64 & int8 support
2 participants