Skip to content

Commit

Permalink
docs: remove RocksDB (#23212)
Browse files Browse the repository at this point in the history
Co-authored-by: Marko <[email protected]>
  • Loading branch information
robert-zaremba and tac0turtle authored Jan 7, 2025
1 parent ead1b1c commit b0031a1
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 25 deletions.
2 changes: 0 additions & 2 deletions scripts/build/build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ DOCKER := $(shell which docker)
PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git)
COSMOS_BUILD_OPTIONS += ' v2'

rocksdb_version=v9.7.3

ifeq ($(findstring .,$(VERSION)),)
VERSION := 0.0.0
endif
Expand Down
7 changes: 2 additions & 5 deletions scripts/go-lint-all.bash
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@

set -e

REPO_ROOT="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )/.." &> /dev/null && pwd )"
REPO_ROOT="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")/.." &>/dev/null && pwd)"
export REPO_ROOT

LINT_TAGS="e2e,ledger,test_ledger_mock"
if [[ ! -z "${ROCKSDB:-}" ]]; then
LINT_TAGS+=",rocksdb"
fi
export LINT_TAGS

lint_module() {
Expand Down Expand Up @@ -53,4 +50,4 @@ else
echo "linting github.com/cosmos/cosmos-sdk [$(date -Iseconds -u)]"
golangci-lint run ./... -c "${REPO_ROOT}/.golangci.yml" "$@" --build-tags=${LINT_TAGS}
fi
fi
fi
4 changes: 2 additions & 2 deletions server/v2/store/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ The pruning option is provided via the 'pruning' argument or alternatively with
- custom: allow pruning options to be manually specified through 'pruning-keep-recent'
Note: When the --app-db-backend flag is not specified, the default backend type is 'goleveldb'.
Supported app-db-backend types include 'goleveldb', 'rocksdb', 'pebbledb'.`,
Example: fmt.Sprintf("%s prune custom --pruning-keep-recent 100 --app-db-backend 'goleveldb'", "<appd>"),
Supported app-db-backend types include 'goleveldb', 'pebbledb'.`,
Example: "<appd> prune custom --pruning-keep-recent 100 --app-db-backend 'goleveldb'",
Args: cobra.RangeArgs(0, 1),
RunE: func(cmd *cobra.Command, args []string) error {
// bind flags to the Context's Viper so we can get pruning options.
Expand Down
20 changes: 4 additions & 16 deletions server/v2/testdata/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,13 @@ proxy_app = "tcp://127.0.0.1:26658"
# A custom human readable name for this node
moniker = "aurn-node"

# Database backend: goleveldb | cleveldb | boltdb | rocksdb | badgerdb
# Database backend: goleveldb | pebbledb
# * goleveldb (github.com/syndtr/goleveldb - most popular implementation)
# - pure go
# - stable
# * cleveldb (uses levigo wrapper)
# - fast
# - requires gcc
# - use cleveldb build tag (go build -tags cleveldb)
# * boltdb (uses etcd's fork of bolt - github.com/etcd-io/bbolt)
# - EXPERIMENTAL
# - may be faster is some use-cases (random reads - indexer)
# - use boltdb build tag (go build -tags boltdb)
# * rocksdb (uses github.com/tecbot/gorocksdb)
# - EXPERIMENTAL
# - requires gcc
# - use rocksdb build tag (go build -tags rocksdb)
# * badgerdb (uses github.com/dgraph-io/badger)
# - EXPERIMENTAL
# - use badgerdb build tag (go build -tags badgerdb)
# * pebbledb (uses github.com/cockroachdb/pebble)
# - stable
# - pure go
db_backend = "goleveldb"

# Database directory
Expand Down
4 changes: 4 additions & 0 deletions store/v2/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

### API Breaking

* [#23157](https://github.com/cosmos/cosmos-sdk/pull/23157) Remove support for RocksDB.

## [v2.0.0-beta.1](https://github.com/cosmos/cosmos-sdk/releases/tag/store/v2.0.0-beta.1)

Initial tag of `cosmossdk.io/store/v2`.

0 comments on commit b0031a1

Please sign in to comment.