-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(x/staking): use cosmossdk.io/core/codec
instead of github.com/cosmos/cosmos-sdk/codec
#23289
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -3,9 +3,8 @@ package v6 | |||||||||||||||||
import ( | ||||||||||||||||||
"context" | ||||||||||||||||||
|
||||||||||||||||||
"cosmossdk.io/core/codec" | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix import ordering. The imports need to be reordered according to the project's guidelines: import (
"context"
storetypes "cosmossdk.io/store/types"
- "cosmossdk.io/core/codec"
+
+ "cosmossdk.io/core/codec"
)
🧰 Tools🪛 golangci-lint (1.62.2)8-8: File is not (gci) 🪛 GitHub Actions: Lint[error] 6-8: File is not properly formatted with gci. Import ordering needs to follow: --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix import ordering. The imports need to be ordered according to the following pattern:
import (
"context"
storetypes "cosmossdk.io/store/types"
- "cosmossdk.io/core/codec"
+
+ "cosmossdk.io/core/codec"
) 📝 Committable suggestion
Suggested change
🧰 Tools🪛 golangci-lint (1.62.2)8-8: File is not (gci) 🪛 GitHub Actions: Lint[error] 6-8: File is not properly formatted with gci. Import ordering needs to follow: --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order |
||||||||||||||||||
storetypes "cosmossdk.io/store/types" | ||||||||||||||||||
|
||||||||||||||||||
"github.com/cosmos/cosmos-sdk/codec" | ||||||||||||||||||
) | ||||||||||||||||||
|
||||||||||||||||||
// MigrateStore performs in-place store migrations from v5 to v6. | ||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix import ordering to match project guidelines.
The imports need to be reordered following the project's guidelines: standard libs, default libs, cosmossdk.io prefixed imports, and github.com/cosmos/cosmos-sdk prefixed imports.
🧰 Tools
🪛 golangci-lint (1.62.2)
8-8: File is not
gci
-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
🪛 GitHub Actions: Lint
[error] 6-8: File is not properly formatted with gci. Import ordering needs to follow: --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order