[WIP] Remote changes order #1573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing that the following assumptions are not all verified in the
resulting order from the remote change sorter:
- alphabetical order
- conflicts before anything else on same id
- deletion before addition on same id
To simulate the directory move from `src/dir` to `dst/dir` on a remote client, we were creating the destination folders and files and remove the sources instead of applying a folder move as the actual implementation does.
taratatach
force-pushed
the
remote-changes-order
branch
from
64056f9 to
758c4fb
Compare
taratatach
force-pushed
the
master
branch
2 times, most recently
from
8a36ecb to
a9a996e
Compare
taratatach
force-pushed
the
master
branch
2 times, most recently
from
8d7d624 to
18fc74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked: