fix: Setup Desktop before opening notes on macOS #2369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop registers with the OS as being able to open Cozy Note
documents. Thus, when a user opens a local
.cozy-note
file Desktopopens the associated note in the default browser.
On Linux and Windows we receive one of two events depending on the
state of the application when the file is opened:
second-instance
when Desktop was already runningready
when Desktop was not runningIn both cases the file path is found in the execution arguments.
On macOS however, the file path will be made available via a dedicated
open-file
event in both situations.When the application is not running though, we'll also receive a
ready
event after theopen-file
event.This is where we encountered a deadlock situation:
ready
event, we setup the application and startthe synchronization unless asked not to (e.g. when opening a note
while Desktop was not already running)
open-file
event, we request not to start thesynchronization if the application was not already running but need
to wait for the setup to complete to open the note
The setup process was only run if the synchronization should be
started or a note file path was passed as argument which only occurs
on Linux and Windows.
Therefore, the app was stuck, ever waiting for the setup process to
complete.
We now make sure the setup process is run as long as we have a valid
config.
Please make sure the following boxes are checked: