Unordered compare diamond nodes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bretbrownjr @dcbaker Could you please take a look at this PR? |
bretbrownjr
reviewed
May 22, 2024
bretbrownjr
approved these changes
May 24, 2024
There was a problem hiding this comment.
Let's land this!
@dcbaker had a good point that we might need to exactly replicate the ordering that pkg-config would provide with analogous metadata. I think that's a valid thought that we can revisit with another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #80, for diamond chain there is no guarantee for the order of topological same-level nodes.
As the test case
component diamond, it may fail in some platforms, such as MacOS.This PR fix the fail by comparing nodes without considering their order.
Before:
After: