-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEMO] Native html pip elemnt #1300
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi @alex-Arc , could you please compile a small list of bullet point pros and cons? |
1faf3b9
to
f88ee6b
Compare
located at
/pop
as opposed to #1274 this dose not need to create a video element to accomplish this
and can reuse our html as is (looks to, not all react stuff will be available)
to down side are that the feature is
Experimental
and not fully supportedDocumentPictureInPicture
from my testing it works in chrome but not in firefox
and there is a small header for the pip element that i'm trying to see if can be removed
@Haavard15 could you have a look