Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Chakra V3 Upgrade #1438

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open

feat(ui): Chakra V3 Upgrade #1438

wants to merge 106 commits into from
+4,137 −3,359

Conversation

asharonbaltazar
Copy link
Collaborator

@asharonbaltazar asharonbaltazar commented Jan 7, 2025 •
edited
Loading

Move Chakra from V2 to V3

  • updates to theming logic (recipes, slotRecipes)
  • move to compositional UI logic
  • many, many import path updates
  • minor updates to stylesheets when applicable
  • update ContextMenu logic to use new Chakra MenuContextTrigger
  • update all icons to use react-icons/iconLib and remove @react-icons

Known Issues ⚠️
Some positioning issues with absolute icons in the EventEditor
Screenshot 2025-01-06 at 8 12 15 PM

Chakra removed the AlertDialog component
Screenshot 2025-01-06 at 8 12 46 PM

Event title is visible through tooltip content
Screenshot 2025-01-06 at 8 13 26 PM

Close button is slightly smaller
Screenshot 2025-01-06 at 8 14 12 PM

There could be other issues with components I had not been able to test due to my limited knowledge around the app

asharonbaltazar and others added 30 commits December 17, 2024 16:24
@asharonbaltazar
chore: initial changes towards upgrade
5b3194e
@asharonbaltazar
chore: some more component updates
52d5048
@asharonbaltazar
chore: update bundling ts config for server
282ec8f
@asharonbaltazar
chore: more changes
b4dca3c
@asharonbaltazar
fix: resolve theming issues
80926b9
@asharonbaltazar
chore: improve types and props
47aeb15
@asharonbaltazar
fix: CuesheetTableSettings
62e69ef
@asharonbaltazar
fix: use correct component
2ae222e
@asharonbaltazar
fix: address issues with ViewParamsEditor
72b66f7
@asharonbaltazar
chore: stuff that needs to be worked on
77de6ee
@asharonbaltazar
chore: fix button imports
e2feabb
@asharonbaltazar
chores: small adjustments
5fe379a
@asharonbaltazar
fix: Switch works with Controller
186084b
@asharonbaltazar
chore: move ui into components
ac915bd
@asharonbaltazar
chore: create IconButton with disabled prop
0a3585f
@asharonbaltazar
fix: update disclosure property
17b88fb
@asharonbaltazar
chore: format popover.tsx
c3365c2
@asharonbaltazar
Merge branch 'master' into v3-upgrade
facccf3
@asharonbaltazar
chore: move to MenuRoot
bf337f7
@cpvalente
fix: issue with persistent script
0abce6f
@asharonbaltazar
Merge remote-tracking branch 'origin/fix-turbo-dev' into v3-upgrade
f513bee
@asharonbaltazar
Merge branch 'master' into v3-upgrade
29d3cf0
@asharonbaltazar
fix: tooltip error
2f9bf60
@asharonbaltazar
fix: font and icon sizes, fix theme recipes
0fccc77
@asharonbaltazar
Merge branch 'master' into v3-upgrade
d7ea152
@asharonbaltazar
chore: delete and update ui components
435f5e3
@asharonbaltazar
chore: more spacing and sizes improvements for buttons
700cd30
@asharonbaltazar
chore: missing style improvements
cafc7aa
@asharonbaltazar
chore: remove backdrop
062a022
@asharonbaltazar
Merge branch 'master' into v3-upgrade
a40a8ea
cpvalente
cpvalente approved these changes Jan 11, 2025
View reviewed changes
Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need some small changes but remarkably few given the size of the PR.
great work!

apps/client/src/common/components/navigation-menu/NavigationMenu.module.scss Outdated Show resolved Hide resolved
apps/client/src/common/components/view-params-editor/ViewParamsEditor.tsx Outdated Show resolved Hide resolved
apps/client/src/common/components/client-modal/RedirectClientModal.module.scss Outdated Show resolved Hide resolved
apps/client/src/common/components/client-modal/RedirectClientModal.tsx Outdated Show resolved Hide resolved
apps/client/src/common/components/input/time-input/TimeInputWithButton.tsx Outdated Show resolved Hide resolved
apps/client/src/views/cuesheet/cuesheet-table/cuesheet-table-elements/EventRow.tsx Outdated Show resolved Hide resolved
apps/client/tsconfig.json Outdated Show resolved Hide resolved
apps/server/package.json Outdated Show resolved Hide resolved
e2e/tests/features/203-delay-block.spec.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
cpvalente
cpvalente requested changes Jan 11, 2025
View reviewed changes
Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(accidentally approved)

asharonbaltazar and others added 21 commits January 13, 2025 12:08
@asharonbaltazar
chore: review comments addressed
c50b08a
@asharonbaltazar
Merge branch 'master' into v3-upgrade
6617c3c
@asharonbaltazar
chore: more review implementations
d9ced54
@asharonbaltazar @cpvalente
chore: add comment for clarity on gap value
ed80180 
Co-authored-by: Carlos Valente <[email protected]>
@asharonbaltazar
chore: update css values
3dc1fa1
@asharonbaltazar
chore: removed unused tab recipe
8055995
@asharonbaltazar
chore: more review comments
d06d5bf
@asharonbaltazar
chore: fix menu opening
8f05aa2
@asharonbaltazar
revert: package downgrades
7630b4d
@asharonbaltazar
chore: prefer individual imports
87e2b6f
@asharonbaltazar
chore: update pnpm-lock file
8abd40a
@asharonbaltazar
chore: import ordering
5c421a1
@asharonbaltazar
fix: standardize pin input height
f1e4291
@asharonbaltazar
fix: align enter button in pin input
f1c9e0a
@asharonbaltazar
fix: consistent outline colors and measurements
3f9d2f2
@asharonbaltazar
fix: remove stepper buttons for browsers
89172b4
@asharonbaltazar
chore: adjust switch theming logic
3156b0b
@asharonbaltazar
chore: add comment to tsconfig for clarity on value
5b3e600
@asharonbaltazar
revert: usage of getByTestId in delay test
6d010e5
@asharonbaltazar
fix: remove zIndex fix for drawer and select
c496c36
@asharonbaltazar
feat: add documentation for chakra-ui typegen
25c675a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-Arc alex-Arc alex-Arc approved these changes

@cpvalente cpvalente Awaiting requested review from cpvalente

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
priority Issue or PR to be prioritised
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asharonbaltazar @alex-Arc @cpvalente