-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace framer #1441
base: v3-upgrade
Are you sure you want to change the base?
Replace framer #1441
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Great initiative @alex-Arc Could this help? Otherwise I haven’t tested the animations but it looks like an improvement |
<AppContextProvider> | ||
<BrowserRouter basename={baseURI}> | ||
<div className='App'> | ||
<LazyMotion features={domAnimation}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: we only use Framer in the views. could we lazy load it there instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we only use it in timer/public/backstage
this lazy load stuff is a bit beound me, I'm unsure of how and the conserveness
Feel free to make a change here
replace
framer-motion
withmotion
and load as little as possibleReduce bundle size
takes us from 334.81kb to 215.79kb
might be able to do more but unsure how