-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch client updates #1448
Batch client updates #1448
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7ad90e3
to
bd9e655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice to me, just left a small improvement suggestion
remember to squash all the fixup commits before merging
449fdde
to
d345716
Compare
d345716
to
023b462
Compare
The goal here is to stabilize runtimestate so that calculations that combine data from runtime or timer and clock don't have incorrect data in the time between receiving the two datasets. Without affecting the mitigations we tried to put in place for #940
this is attempted to be done by allowing ws client to subscribe to either a key model or a patch model when connectionall data written to
eventStore.set
will be batch with usingsetImmediate
so it should be sent next eventloop tick but all the data set will be sent together