Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated test cases from target-postgres, they are validating now #9

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 14, 2023

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2b20640) 80.11% compared to head (ac15e13) 82.23%.

Files Patch % Lines
target_cratedb/tests/test_standard_target.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   80.11%   82.23%   +2.11%     
==========================================
  Files           7        7              
  Lines         679      681       +2     
==========================================
+ Hits          544      560      +16     
+ Misses        135      121      -14     
Flag Coverage Δ
main 82.23% <82.85%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the types-1 branch 6 times, most recently from b0aa3a8 to 3ddc350 Compare December 16, 2023 03:56
@amotl amotl requested review from seut, matriv and surister December 16, 2023 05:44
@amotl amotl marked this pull request as ready for review December 16, 2023 05:45
Base automatically changed from types-1 to main December 21, 2023 19:30
@amotl amotl merged commit 2cfd7bb into main Dec 21, 2023
4 checks passed
@amotl amotl deleted the tests branch December 21, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant