Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symphony 2.4 update #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jonmifsud
Copy link

XML Context does not contain a string but rather an XML Element - Note this update should break support for 2.3 so best updated with a New tag version.

@jurajkapsz
Copy link

So this update also shifts the assets XML data node under /data/params?

'Cause before the assets node was a child element of /data.

@jonmifsud
Copy link
Author

Oh yes you're right! seeing the params in the match function must have confused me; I'll try patch it tomorrow hopefully nothing to complicated.

@jurajkapsz
Copy link

Ok. Anyway a great fix. Thanks!

@jonmifsud
Copy link
Author

updated with the proper code - should be now working as expected

@jurajkapsz
Copy link

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants