Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Windows] Maximize the window over the taskbar in the fullscreen mode. #311

Open
wants to merge 618 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
618 commits
Select commit Hold shift + click to select a range
75f0180
Incrementing VERSION to 48.0.2564.49
Dec 17, 2015
fed6883
Fix a regression caused by my change to make the first run bubble win…
Dec 17, 2015
b006def
Fix a snackbar crash about leaking window
jollycopper Dec 17, 2015
2211e50
Always fire refresh tokens loaded on ChromeOS.
Dec 17, 2015
c3da897
[Cast,Android,Presentation API] Send messages back to the right clien…
avayvod Dec 17, 2015
586e9b8
[Cast, Android, Presentation API] Fix the logic for showing controlle…
avayvod Dec 17, 2015
06c212a
Force Account Consistency off for Logout call on iOS.
Jicks Dec 17, 2015
38b1a83
[Mac] Fix regression where commands were disabled in full screen.
asvitkine-chromium Dec 17, 2015
f0d5dfd
[extensions] Update content_capabilities whitelists
krockot Dec 17, 2015
7b09337
Bug fix: Show mouse cursor during full screen share on ChromeOS.
Dec 17, 2015
e352455
Reader Mode cannot be permanently disabled
iotitan Dec 17, 2015
e9159b5
Disable HTML close button in Reader Mode
iotitan Dec 17, 2015
8e0394f
Extend Reader Mode animation time
iotitan Dec 17, 2015
1731f83
Disabled custom fullscreen animation for entering tab fullscreen sinc…
Dec 17, 2015
890c56e
[Cast, Android, Presentation API] Implement ReceiverAction messages.
avayvod Dec 17, 2015
0ee4d44
[Blob] Fix for resetting reader.
dmurph Dec 17, 2015
f85263d
Only set -rpath=$ORIGIN in component builds by default.
Dec 17, 2015
53396d3
Use correct width for narrow panel in Reader Mode
iotitan Dec 18, 2015
18f4e30
Incrementing VERSION to 48.0.2564.50
Dec 18, 2015
a3d15b0
Fix ContentViewCore height for fullscreen panel
iotitan Dec 18, 2015
af7e7ed
Merged: Trigger MSE players UMA by user events only
Dec 18, 2015
ceb1bca
bindings: Fixes [LenientThis] to refer to the correct object.
yuki3 Dec 18, 2015
3364ba0
Add two UseCounters for form.imageName and form.elements.imageName.
tkent-google Dec 18, 2015
417f8f8
Disable enumeration caching for output devices.
magjed Dec 18, 2015
40f8e22
fix to run Webview Policy initialization on the UI thread
Dec 18, 2015
75c6c91
autofill: save pasted passwords on Mac
Dec 18, 2015
963a085
Before finalizing scroll dimensions, check again whether we need scro…
cbiesinger Dec 18, 2015
b29eb69
Center static icon
iotitan Dec 18, 2015
1e40386
Incrementing VERSION to 48.0.2564.51
Dec 18, 2015
2127544
Adding CRWWebViewContentView as a subview when it is set
Dec 18, 2015
d5b9e0f
[MR UI] Fix bug with clearing issue in WebUI.
Dec 18, 2015
6307ed6
[ios] Implemented basic HTTP Authentication for WKWebView.
Dec 19, 2015
3b46839
Don't toggle sync on/off on account rename.
Dec 19, 2015
ecc529f
Incrementing VERSION to 48.0.2564.52
Dec 19, 2015
fd62a21
Incrementing VERSION to 48.0.2564.53
Dec 20, 2015
b65babc
Web Animations: Fix scheduling loop in race between visibility and st…
dstoc Dec 20, 2015
58383a4
Fix a crash by search event handler for <input type=search incremental>.
tkent-google Dec 21, 2015
01139ac
Incrementing VERSION to 48.0.2564.54
Dec 21, 2015
81936ef
[Merge to M-48] Fix saving password in Password Manager on nytimes.com.
Dec 21, 2015
75e9178
Don't load WebUI if provisional navigation is for non-chrome URL
Dec 21, 2015
f5d4da8
Set the initial transition type and initial intent on custom tabs
Dec 21, 2015
74d034b
Fix broken build
Dec 21, 2015
48aea58
[M48] Make InfoBarControlLayouts more aesthetically pleasing
Dec 21, 2015
2c5fb2f
[GCM] Fix error handling for corrupted protos.
Dec 21, 2015
e30afae
Start keeping state about https emphasis on LocationBarLayout
Dec 21, 2015
d272486
Mac: Don't repaint scrollbars every frame
ccameron-chromium Dec 21, 2015
0d3e5e8
[ios] Suppress crash caused by dereferenced null NI pointer.
Dec 22, 2015
c54e0e8
Fix official build (header renamed)
ccameron-chromium Dec 22, 2015
fb4ef65
Incrementing VERSION to 48.0.2564.55
Dec 22, 2015
4d62c4c
V4L2SVDA: Pass (0,0) visible rect to PictureReady().
Dec 22, 2015
60bc5eb
Fix beta compilation
Dec 22, 2015
fa825e3
Merge "Revert of Invalidate scrolling contents on scrolling contents …
wangxianzhu Dec 22, 2015
9ce09b2
Updating XTBs based on .GRDs from branch 2564
Dec 22, 2015
e10ad48
Adding the mime type explicitly for WebUI page loads.
shreyasva Dec 22, 2015
76369f7
[Contextual Search] Allow disabling remotely.
Dec 22, 2015
3a1bdf2
Fix merge
Dec 22, 2015
c27ca2f
Replaced use of deprecated kCLAuthorizationStatusAuthorized
Dec 22, 2015
edacfde
Removed use of deprecated stringByReplacingPercentEscapesUsingEncoding:
Dec 22, 2015
a9a1fa1
Removed another use of deprecated stringByReplacingPercentEscapesUsin…
Dec 22, 2015
6bf6161
Removes use of deprecated -applicationFrame
Dec 22, 2015
d93f762
Incrementing VERSION to 48.0.2564.56
Dec 23, 2015
5f62269
[Cast, Android] Always call stopApplication() when handling the notif…
avayvod Dec 23, 2015
a66e857
[Cast, Android] Don't send messages to _receiver-action clients
avayvod Dec 23, 2015
8f373dd
Incrementing VERSION to 48.0.2564.57
Dec 24, 2015
23d0bb0
Incrementing VERSION to 48.0.2564.58
Dec 25, 2015
db0742e
Incrementing VERSION to 48.0.2564.59
Dec 26, 2015
dfbe270
Incrementing VERSION to 48.0.2564.60
Dec 27, 2015
fe04ea0
Incrementing VERSION to 48.0.2564.61
Dec 28, 2015
8069d0c
Updating XTBs based on .GRDs from branch 2564
Dec 28, 2015
0753afb
Fix handling of wildcards in administrative/unilateral name constraints.
matt-mueller Dec 28, 2015
9f58569
[Merge] Mac: Don't consider default-installed apps as being created f…
tapted Dec 28, 2015
627b8e7
Incrementing VERSION to 48.0.2564.62
Dec 29, 2015
af6190a
Checking for valid header name, value before adding them.
shreyasva Dec 29, 2015
50800b7
Incrementing VERSION to 48.0.2564.63
Dec 30, 2015
0e3bc97
Incrementing VERSION to 48.0.2564.64
Dec 31, 2015
961b85b
Gracefully discharge a failed script load in disposed documents.
sigbjornf Dec 31, 2015
18a464f
Incrementing VERSION to 48.0.2564.65
Jan 1, 2016
2d2d006
Incrementing VERSION to 48.0.2564.66
Jan 2, 2016
b03f306
Incrementing VERSION to 48.0.2564.67
Jan 3, 2016
4dfffbf
Incrementing VERSION to 48.0.2564.68
Jan 4, 2016
73b2d75
Ensure input connection to be created on pressing next button
galmacky Jan 4, 2016
63c90f8
Merge: Don't block tasks unless we've seen a touchstart
Jan 4, 2016
f65878b
Merge https://codereview.chromium.org/1533543002 into M48
Jan 4, 2016
75b44ae
Updating XTBs based on .GRDs from branch 2564
Jan 4, 2016
c5e1b9c
Make WebController isViewAlive method check if the web process is alive.
Jan 4, 2016
6b2b089
[ios] Removed deprecated cancelJavaScriptDialogsForWebController.
Jan 4, 2016
1aefda1
Use userInteractionRegistered for transition determination in pushState
Jan 4, 2016
6d057ac
Hide Reader Mode panel when FIP showing
iotitan Jan 4, 2016
16294c7
[Android] Use exact string matching for some devices for default mode…
Jan 4, 2016
c215a80
AlternativeService - change the expiration time from 1 day to 30 days.
Jan 4, 2016
af4f0f6
ash::ImeController should not crash if IME is not initialized yet
Jan 4, 2016
de1a84c
Make sure LocalFrame reference is protected during FrameLoader::init
zetafunction Jan 4, 2016
4e0a4f9
Fix search google for image in iframes.
Jan 4, 2016
7e60c1d
Merged: Catch all possible exceptions from MediaCodec.configure()
Jan 5, 2016
9eb7a5f
Enable tabbed mode for new users.
Jan 5, 2016
c3ead76
Fixed use-after-free bug in ChainedBlobWriterImpl.
cmumford Jan 5, 2016
44503cb
Incrementing VERSION to 48.0.2564.69
Jan 5, 2016
7233e86
Don't route a non-frame widget's keyboard event to main frame widget.
Jan 5, 2016
a95de64
Fix underline composition to draw correctly for RTL text
galmacky Jan 5, 2016
9aa53d1
<marquee behavior="alternate"> should work correctly
xharaken Jan 5, 2016
ae83c1a
Make SelectionEditor::setWithoutValidation() not to use obsoleted la…
yosinch Jan 5, 2016
017eb28
Merge M48: Remove the scheduler from the PPAPI thread
Jan 5, 2016
e56d5f3
[DownloadNotification Test] Use temporary download directory
yoshikig Jan 5, 2016
26fcb5c
Keyboard events with keypad had wrong keycodes on ozone.
dtapuska Jan 5, 2016
06a4732
Incrementing VERSION to 48.0.2564.70
Jan 5, 2016
99afddf
Adding subviews in didMoveToSuperview instead
shreyasva Jan 5, 2016
42b9a3d
Add UMA stats for Reader Mode
iotitan Jan 5, 2016
3e444d3
Fix bug where custom cursors would disappear when screen was rotated …
mspang Jan 5, 2016
d4345ac
[ios] Make sure that |didFinishNavigation| is signalled for fast goBack.
Jan 5, 2016
2639e87
Don't allow inline install if frame is deleted before user accepts
Jan 5, 2016
a200eaf
Make the webstore inline install dialog be tab-modal
Jan 5, 2016
7367f86
Only set nil serialized state for history.pushState() navigations.
Jan 5, 2016
3e791e6
Don't fire popstate events for cross-document loads
Jan 5, 2016
4bd4c9c
PepperCdmWrapperImpl::Create() fails on URL mismatch.
xhwang-chromium Jan 6, 2016
17435f3
Fix for unclickable media indicator while NumLock is on.
miu-chromium Jan 6, 2016
7b35649
Incrementing VERSION to 48.0.2564.71
Jan 6, 2016
6ef937e
Stop-gap solution for Android DPAD navigation
galmacky Jan 6, 2016
54b98cb
Fix content size bug for WKWebView.
Jan 6, 2016
8759678
Fix SVGInlineTextMetricsIterator not to keep a pointer to LineLayoutItem
kojiishi Jan 6, 2016
80d6815
Ignore pushState events if there is a pending NavigationItem.
Jan 6, 2016
2aedd8e
Keep original pushState() method for use in JS overwrite
Jan 6, 2016
49e2e9f
Disable Reader Mode panel in accessibility mode
iotitan Jan 6, 2016
d3e24af
[Contextual Search] Switch off the translation one-box.
Jan 6, 2016
3ca48ac
Make WKWebView the default experiment value for eligible users
Jan 6, 2016
7f97673
Roll third_party/freetype-android/src to VER-2-6-2.
jungshik Jan 6, 2016
13ecfb7
Revert "Roll third_party/freetype-android/src to VER-2-6-2."
jungshik Jan 6, 2016
5347cfe
Roll third_party/freetype-android/src to VER-2-6-2.
jungshik Jan 6, 2016
3139ebe
Fix a bug generating black preview screen
tommynyquist Jan 6, 2016
bfbadc9
Incrementing VERSION to 48.0.2564.72
Jan 6, 2016
a1c18d5
Incrementing VERSION to 48.0.2564.73
Jan 6, 2016
ad04bee
Incrementing VERSION to 48.0.2564.74
Jan 7, 2016
890b7c9
Fix a crash in HTMLInputElement::onSearch.
tkent-google Jan 7, 2016
f98c59d
Select element should not dispatch 'change' event with form reset and…
tkent-google Jan 7, 2016
1f0ddeb
Check for invalid URL during pushState flow.
Jan 7, 2016
421ec44
[Contextual Search] Fix merge issue with recent commit.
Jan 7, 2016
9409e4e
Use standard font for print preview
iotitan Jan 7, 2016
ace1321
Incrementing VERSION to 48.0.2564.75
Jan 8, 2016
d5501df
Fix the issue that Caps-Lock doesn't work.
shuchen-google Jan 8, 2016
4636583
Fix infinite recursion with CRWWebController's _requireReloadOnDisplay
Jan 8, 2016
a4e70c9
Check that current navigation item exists before inspecting history list
Jan 8, 2016
0962d81
Recompute scroll origin when scrollbar existence has changed.
szager-chromium Jan 8, 2016
2449cdf
GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes()
hshi-chromium Jan 8, 2016
083b629
Traverse into subdocuments when mapping plugin rects from absolute to…
Jan 8, 2016
3562a01
Do not overwrite the valid layout data with old invalid data.
mitoshima Jan 8, 2016
e15b333
[Merge M48] [TabManager] Add flag to disable tab discarding.
georgesak Jan 8, 2016
54a8fe4
Pass ResourcePtr<Resource> from ResourceFetcher::preCacheData
natechapin Jan 8, 2016
9c459b2
customtabs: Fix "about:blank" URL after a complete prerender.
Jan 8, 2016
04128e7
Incrementing VERSION to 48.0.2564.76
Jan 9, 2016
05c8ae0
Handle invalid hardware output parameters in AudioRendererHost.
Jan 11, 2016
5674351
Add JSON serializer to MediaDeviceInfo.
Jan 11, 2016
33cbe8c
[Merge M48] Remove support for chrome_shortcut_icon_index master_pref.
Jan 11, 2016
1f9ac4c
[Merge] Custom buttons should only handle accelerators when focused.
adrifelt Jan 11, 2016
a93bb2b
Implementation for Look Up on Force Touch. If the user force touched …
Jan 11, 2016
ca5ef94
Defer widget updates in ContainerNode::parserRemoveChild.
oliverchang Jan 11, 2016
8110ea5
Merge to 2564 "[DevTools] Fix custom user agent override not applying."
dgozman Jan 11, 2016
0599441
Updating XTBs based on .GRDs from branch 2564
Jan 11, 2016
c04e421
Fix volume slider to emit value changed events and do not focus syste…
dtsengchromium Jan 11, 2016
ce67989
cc: Avoid crash on Android in GLRenderer
Jan 11, 2016
3e432b9
Fix NTP after rotation in the tab switcher.
Jan 11, 2016
8278203
Refresh Public Suffic List to the latest version
sleevi Jan 11, 2016
2a1d966
Fix double resource request for script resources with integrity attr.
joelweinberger Jan 11, 2016
3c29f67
Clear integrity failure bit in PendingScript on release
joelweinberger Jan 11, 2016
0a0f503
[Merge M48] Fix jar_toc.py to include public/protected methods
Jan 11, 2016
e61ee7e
CSS Invalidation: Avoid virtual functions in InvalidationSet
ericwilligers Jan 11, 2016
43b12cf
Fix ImeTest failure
galmacky Jan 12, 2016
5be78ef
Incrementing VERSION to 48.0.2564.77
Jan 12, 2016
1606cde
Reset browser.check_default_browser on browser update.
jschuh Jan 12, 2016
31a5b74
New experiment without registry deletion
jschuh Jan 12, 2016
9f80eae
Fix null dereference on MemoryCache.
yutakahirano Jan 12, 2016
ab830ed
CSP: Source expressions can no longer lock sites into insecurity.
mikewest Jan 12, 2016
c1c8546
Don't try to store POST data for a nil CWRSessionEntry
Jan 12, 2016
750369b
Handle saved password deletion when preference has been recreated
Jan 12, 2016
eb4903f
Merge M48: Update Flash plugin metadata versions to latest version.
wfh-chromium Jan 12, 2016
5f2f77f
Remove clientWidth call during MediaControls::reset.
liberato-at-chromium Jan 12, 2016
8b349ff
Do not prompt and/or create copies when Android logins are filled int…
Jan 12, 2016
c0118af
[Sync] Make InvalidationPreferences.commit() thread-safe.
Jan 12, 2016
e39ed6c
Pull the Activity context from WindowAndroid if possible
Jan 12, 2016
a749977
Clank VideoCaptureCamera, speculative crash fix in getCameraParameters()
yell0wd0g Jan 12, 2016
3bfc748
Incrementing VERSION to 48.0.2564.78
Jan 13, 2016
3a833a2
Allow GPU channels to be created when using SwiftShader
pimanttr Jan 13, 2016
c488b33
Revert of Fix null dereference on MemoryCache. (patchset #1 id:1 of h…
yutakahirano Jan 13, 2016
240bcd0
Incrementing VERSION to 48.0.2564.79
Jan 13, 2016
b0e1a1a
Fix null dereference on MemoryCache.
yutakahirano Jan 13, 2016
1308f9c
Ignore WP switch for auto-enrollment decision.
thiemonagel Jan 13, 2016
1f25e3d
attestation: Fix policy observer expiry check.
darrenkrahn Jan 13, 2016
d364f29
Prevent a race condition with MidiHost IPC sending.
oliverchang Jan 13, 2016
202327d
Incrementing VERSION to 48.0.2564.80
Jan 13, 2016
2868dc9
Merge to M48: [SafeBrowsing] Always prompt for some file types.
asankah Jan 13, 2016
04fbd39
Roll DOM Distiller JavaScript distribution package
iotitan Jan 13, 2016
3668a3d
Incrementing VERSION to 48.0.2564.81
Jan 13, 2016
cfdc31d
Fix crash by not creating new print dialogs when distilling a page.
hcarmona Jan 14, 2016
4091f91
Fix NULL crash in PrintViewManager::PrintPreviewDone.
hcarmona Jan 14, 2016
a8ca79e
Make sure there is wrapped activity in WindowAndroid for SelectPopUp
Jan 14, 2016
b3cb492
Move RevenueStats logic out of Tab constructor
Jan 14, 2016
8416952
Lazily allocate CastConfigDelegate to fix profile construction race.
jacobdufault-google Jan 15, 2016
6b53888
Incrementing VERSION to 48.0.2564.82
Jan 15, 2016
00a9fbe
Publish DEPS for Chromium 48.0.2564.82
Jan 15, 2016
b5ab72b
.gitignore: Ignore xwalk/.
May 3, 2013
e238645
Also need to set aura::Window title
Jul 18, 2013
a25cee2
Add GetFieldID functing to jni_help in the content for XWalk.
junmin-zhu Nov 17, 2013
1fc0c8d
[SysApps] Expose ffmpeg function signatures needed by Device Capabili…
Nov 26, 2013
fb61355
Fix default min-layout width and scrollbar appearence.
kenchris Dec 5, 2013
f96db1b
[SysApps] Make CodecIDToAudioCodec and CodecIDToVideoCodec available …
Dec 20, 2013
d43f672
[Android] Use the Chromium TLS for thread local storage allocation
Jan 15, 2014
71a0627
[Android] Change the API for ApplicationStatus in base dir.
Apr 1, 2014
5402a8a
[Android] Add a new API to simulate activity started on ApplicationSt…
kurli Apr 8, 2014
fcc99e4
[Android] Ignore status from non tracked activities
kurli Apr 16, 2014
c864851
[Android] Add Resource loading filter for MediaPlayer
Jul 10, 2015
dcea2d5
[Extensions] Build glib message pump on Ozone by default
Jun 9, 2014
71fb0ce
[Android] Fix the crash of GetUserMedia
xingnan Jun 19, 2014
706fd43
[Android] Add a new listener to listen the first rendered frame
kurli Jul 7, 2014
875c44b
Provide a ScreenOrientationDispatcherHost getter.
Jul 7, 2014
9f86bff
[Android] Use TextureView as an alternative compositing surface target
Aug 12, 2014
276f85a
[Android] Only initialize ContentReadbackHandler in onNativeLibraryLo…
Aug 15, 2014
b900edf
.gitignore: Ignore src/third_party/khronos/CL.
Oct 7, 2014
7acce25
[Android] Allow constructor of Notifications on Android.
Jul 10, 2015
88c8a6d
[Android] Implement ContentViewRenderView.setZOrderOnTop
axinging Mar 20, 2015
bd9f198
Add flag to disable hrtf in webaudio
Apr 2, 2015
e0a388c
[ICS Support] Revert "Remove ICS support from build/android/pylib/"
Jul 7, 2015
145e84b
[ICS Support] Revert "Remove ICS support from Chromium code."
Jul 10, 2015
454a8cf
[ICS Support] Revert "Remove JELLY_BEAN checks from GamepadList.java"
Jul 7, 2015
018dba5
[ICS Support] Revert "Remove ICS support in ui/"
Jul 7, 2015
0e94935
[ICS Support] Revert "Remove ICS support code in chrome/ and componen…
Jul 7, 2015
07250d5
[ICS Support] Revert "Remove ICS support in VSyncMonitor."
Jul 10, 2015
0cd02b0
[ICS Support] Revert "Remove ICS check in SwipeRefreshHandler."
Jul 7, 2015
49e5835
[ICS Support] Revert "Remove ICS check in ChromeContextMenuPopulator."
Jul 7, 2015
f31c5c9
[ICS Support] Revert "Remove ICS checks in ExternalNavigationHandler."
Jul 7, 2015
7ecb153
[ICS Support] Revert "Remove ICS code from Clank Cast"
Jul 7, 2015
4c55ea8
[ICS Support] Revert "Remove ICS support in C++ code."
Jul 10, 2015
01e15ce
[ICS Support] Revert "Remove unnecesary ApiCompatibilityUtils calls."
Jul 10, 2015
15bdf21
[ICS Support] Revert "Remove ICS support from SurfaceTexture"
Jul 7, 2015
5c10570
[ICS Support] Revert "Update minSdkVersion and targetSdkVersion const…
Jul 10, 2015
ed5421b
[ICS Support] Revert "Remove AccessibilityInjector support."
Jul 10, 2015
977dc25
[ICS Support] Revert "Remove enable-accessibility-script-injection fl…
Dec 13, 2015
b7d445c
[ICS Support] M46: Suppress lint warnings due to new API.
Sep 29, 2015
5eccdf8
[ICS Support] M48: Adapt to additional Python changes in the M48 cycle.
Jan 15, 2016
0a4b300
[ICS Support] M48: suppress lint warnings due to new API.
Dec 9, 2015
e9e9cf8
Fix build on Windows when using components build.
darktears Aug 11, 2015
f1d6497
[Android] Allow intercepter to extract paks
Feb 28, 2014
7a25a78
[Blink] Exclude impulse wav files is hrtf is disabled
Apr 2, 2015
c9e93e4
[Blink] WebCL support for Crosswalk.
hujiajie May 24, 2015
1001b7e
[Blink] Add in-depth allocation tracker
Oct 2, 2015
c2fc7aa
[Android] Stop using org.apache.http classes in AccessibilityInjector.
Nov 3, 2015
b825729
[Windows]Enable presentation API
Nov 25, 2015
768aa8c
[Android] Expose the constructor of ContentView
Jan 4, 2016
6fbcd3b
[Windows] Support RealSense Cameras
huningxin Dec 17, 2015
9fff7f6
[Backport] Conditionally set CREATE_BREAKAWAY_FROM_JOB when job objec…
Jan 6, 2016
512d729
[Backport] Remove assumption on absolute paths in java_cpp_enum.py.
Jan 12, 2016
72d2469
[Windows] M48 fixup for the Support RealSense Cameras patch
huningxin Jan 21, 2016
a894620
[Windows] Maximize the window over the taskbar in the fullscreen mode.
Jan 20, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ v8.log
/third_party/junit/src
/third_party/kasko
/third_party/khronos_glcts
/third_party/khronos/CL
/third_party/leveldatabase/src
/third_party/leveldb
/third_party/libc++-static/libc++.a
Expand All @@ -347,6 +348,7 @@ v8.log
/third_party/libphonenumber/libphonenumber.xml
/third_party/libphonenumber/libphonenumber_without_metadata.xml
/third_party/libphonenumber/src
/third_party/libpxc
/third_party/libsrtp
/third_party/libupnp
/third_party/libvpx_new/source/libvpx
Expand Down Expand Up @@ -453,3 +455,4 @@ v8.log
/win8/metro_driver/metro_driver_version_resources.xml
/x86-generic_out/
/xcodebuild
/xwalk
55 changes: 45 additions & 10 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,37 @@ declare_args() {
root_extra_deps = []
}

# This file defines the following four main targets:
# This file defines the following five main targets:
#
# "both_gn_and_gyp" should list every root target (target that nothing else
# depends on) built by GN that is also built in the GYP build.
#
# "gn_all" should (transitively) cause everything to be built; if you run
# 'ninja gn_all' and then 'ninja all', the second build should do no work.
#
# "gn_only" should list every root target that is *not* intended to be built
# in a GYP build. Because GN has different rules for deciding what an 'all'
# build is, this may end up including targets that are actually defined in a
# GYP build but not dependencies of GYP's "all" (and so not actually built).
# "gn_only" should list every root target that is *not* intended to be built in
# a GYP build. Because GN has different rules for deciding what an 'all' build
# is, this may end up including targets that are actually defined in a GYP
# build but not dependencies of GYP's "all" (and so not actually built).
#
# "gn_visibility": targets that are normally not visible to top-level targets,
# but are built anyway by "all". Since we don't want any such targets, we
# have this placeholder to make sure hidden targets that aren't otherwise
# depended on yet are accounted for.
# but are built anyway by "all". Since we don't want any such targets, we have
# this placeholder to make sure hidden targets that aren't otherwise depended
# on yet are accounted for.
#
# "All" is an alias for "gn_all". It exists for bot compatibility w/ GYP for
# the iOS bots and the official builders, but should not be generally used
# during the GYP->GN migration. We cannot guarantee that GN's "All" builds the
# same set of targets as GYP's "All" does, because GYP's "All" supports
# wildcards.
#
# Lastly, none of these targets are guaranteed to be the same as what ninja
# will build with "all". For more on how "all" works and the differences in how
# GYP and GN determine "all", see crbug.com/503241.
#
# TODO(GYP): crbug.com/481694. Make sure that the above is true and there are
# scripts run on the bots that enforce this. Once the GYP migration is over,
# we can collapse all of these targets as desired.
# scripts run on the bots that enforce this. Once the GYP migration is over, we
# can collapse all of these targets as desired.

group("gn_all") {
testonly = true
Expand All @@ -57,6 +67,16 @@ group("gn_all") {
]
}

# TODO(GYP): This target exists for compatibility with GYP, specifically
# for the iOS bots and the official builders.
group("All") {
testonly = true

deps = [
":gn_all",
]
}

# The "both_gn_and_gyp" target should reflect every target that is built
# in both the GN and GYP builds, and ideally it should match the
# "both_gn_and_gyp" target in build/gn_migration.gypi line-for-line.
Expand Down Expand Up @@ -331,6 +351,8 @@ group("both_gn_and_gyp") {
if (is_linux) {
# The following are definitely linux-only.
deps += [
"//chrome:manpage",
"//chrome:xdg_mime",
"//dbus:dbus_test_server",
"//dbus:dbus_unittests",
"//net:disk_cache_memory_test",
Expand All @@ -345,6 +367,11 @@ group("both_gn_and_gyp") {
if (is_chromeos || use_ash) {
deps += [ "//components/session_manager/core" ]
}

if (is_chrome_branded && is_official_build) {
# TODO(dpranke): add the linux_dump_symbols flag?
deps += [ "//chrome:linux_symbols" ]
}
}

if (is_ios || is_win || (is_linux && !is_chromeos)) {
Expand Down Expand Up @@ -420,6 +447,14 @@ group("both_gn_and_gyp") {

if (enable_nacl) {
deps += [ "//components/nacl:nacl_loader_unittests" ]

if (is_linux) {
# TODO(dpranke): Figure out what platforms should actually have this.
deps += [
"//components/nacl:nacl_helper",
"//components/nacl:helper_nonsfi",
]
}
}

if (media_use_ffmpeg) {
Expand Down
Loading