Skip to content

Commit

Permalink
Remove ruby 2.7 rails 5.2 per the rules
Browse files Browse the repository at this point in the history
Remove duplicate ruby 3.0 testing
Update documentation to read better
  • Loading branch information
luke-hill committed Sep 10, 2024
1 parent e8b2299 commit e001186
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,35 @@ jobs:
strategy:
fail-fast: false
matrix:
# Latest ruby (3.3), will test
# Latest ruby will only be tested on
# - all rails versions in current major
# - latest rails version in the previous major
#
# Unsupported rubies will test
# - rails versions in each branch if they are released within 6 months of EOL
# - nothing in the current rails major
# Any unsupported ruby will only be tested on
# - rails versions in each branch if their last release is within 6 months of the Ruby EOL date
# - Excluding any version of the current rails major
#
# 2.6 -> Unsupported from March '22 -> Only test up to Sep '22
# 2.7 -> Unsupported from March '23 -> Only test up to Sep '23
# 3.0 -> Unsupported from March '24 -> Only test up to Sep '24
include:
- { ruby: '2.6', gemfile: 'rails_5_2' }
- { ruby: '2.7', gemfile: 'rails_5_2' }
- { ruby: '2.7', gemfile: 'rails_6_0' }
- { ruby: '2.7', gemfile: 'rails_6_1' }
# Ruby 3+ won't work with Rails 5.2: https://github.com/rails/rails/issues/40938
# Capybara has an incompatibility here with rails 6. It's easier to just exclude this one run from the matrix until it's out of support
# As such ruby 3.0 is only tested on rails 7.0 as an exception to the rule
# As such ruby 3.0 is only tested on rails 7.0 as an EXCEPTION to the above rules
- { ruby: '3.0', gemfile: 'rails_7_0' }
- { ruby: '3.3', gemfile: 'rails_6_1' }
- { ruby: '3.3', gemfile: 'rails_7_0' }
- { ruby: '3.3', gemfile: 'rails_7_1' }
- { ruby: '3.3', gemfile: 'rails_7_2' }
# Supported rubies will test all permissible supported rails versions
ruby: ['3.0', '3.1', '3.2']
ruby: ['3.1', '3.2']
gemfile: ['rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0', 'rails_7_1', 'rails_7_2']
exclude:
# Ruby 3.0+ won't work with Rails 5.2: https://github.com/rails/rails/issues/40938
# Ruby 3.1+ has a conflicting Psych version with Rails 6.x: https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
- { ruby: '3.1', gemfile: 'rails_5_2' }
# Ruby 3.1+ has a conflicting Psych version with Rails 6.x: https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
- { ruby: '3.1', gemfile: 'rails_6_0' }
- { ruby: '3.1', gemfile: 'rails_6_1' }
- { ruby: '3.2', gemfile: 'rails_5_2' }
Expand Down

0 comments on commit e001186

Please sign in to comment.