revert: add Athens Go proxy configuration for docker (#8)

* fix: workflow yaml indentation in go-checks

* revert: add Athens Go proxy configuration for docker

Due to this repo being public-facing, it isn't allowed to access the
private composite action in `cultureamp/go-private-modules`. This
results in an error where the go-checks action fails to run because
it is unable to pull the action.

Since this repository is public and not using private deps, we can
undo this change.

* test: update environment variable names
In an earlier commit, the Buildkite environment variable was renamed
to reflect the repo. After this change, the test suite was not running
in CI, hence this wasn't caught in review time.

This change is a follow up to the earlier commit that allows the tests
to pass.

.github/workflows/go-checks.yml

@@ -13,11 +13,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-    - name: Configure Go environment with access to private modules
-      uses: cultureamp/go-private-modules@v1
-      with:
-        github-token: "${{ secrets.GO_PRIVATE_MODULES_TOKEN }}"
-
       - uses: actions/setup-go@v5
         with:
           go-version-file: src/go.mod
@@ -32,11 +27,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Configure Go environment with access to private modules
-        uses: cultureamp/go-private-modules@v1
-        with:
-          github-token: "${{ secrets.GO_PRIVATE_MODULES_TOKEN }}"
-
       - uses: actions/setup-go@v5
         with:
           go-version-file: src/go.mod
@@ -55,11 +45,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Configure Go environment with access to private modules
-        uses: cultureamp/go-private-modules@v1
-        with:
-          github-token: "${{ secrets.GO_PRIVATE_MODULES_TOKEN }}"
-
       - uses: actions/setup-go@v5
         with:
           go-version-file: src/go.mod

docker-compose.yml

@@ -14,7 +14,3 @@ services:
     build:
       context: src
       dockerfile: Dockerfile
-      args:
-        - GONOPROXY
-        - GOPRIVATE
-        - GOPROXY

src/Dockerfile

@@ -25,10 +25,6 @@ RUN go mod verify
 
 COPY . ./
 
-ARG GONOPROXY
-ARG GOPRIVATE
-ARG GOPROXY
-
 # build as a static binary without debug symbols
 RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build \
       -ldflags='-w -s -extldflags "-static"' -a \

src/plugin/config_test.go

@@ -25,7 +25,7 @@ func TestFetchConfigFromEnvironment(t *testing.T) {
 	var config plugin.Config
 	fetcher := plugin.EnvironmentConfigFetcher{}
 
-	t.Setenv("BUILDKITE_PLUGIN_EXAMPLE_GO_MESSAGE", "test-message")
+	t.Setenv("BUILDKITE_PLUGIN_ECS_TASK_RUNNER_MESSAGE", "test-message")
 
 	err := fetcher.Fetch(&config)
 

src/plugin/example_test.go

@@ -15,7 +15,7 @@ func TestDoesAnnotate(t *testing.T) {
 	ctx := context.Background()
 	annotation := "test-message"
 
-	t.Setenv("BUILDKITE_PLUGIN_EXAMPLE_GO_MESSAGE", annotation)
+	t.Setenv("BUILDKITE_PLUGIN_ECS_TASK_RUNNER_MESSAGE", annotation)
 	agent.Mock.On("Annotate", ctx, annotation, "info", "message").Return(nil)
 
 	err := examplePlugin.Run(ctx, fetcher, agent)