Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement E2E workflow for authenticator sidecars in OpenShift and Conjur Enterprise and follower in Jenkins #385

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

imheresamir
Copy link
Contributor

@imheresamir imheresamir commented Aug 18, 2021

What does this PR do?

  • Minor changes to get a new E2E flow working (authenticator sidecars in OpenShift and Conjur Enterprise and follower in Jenkins)
  • Minor cleanups and deflaking

What ticket does this PR close?

Resolves #245

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

Manual tests

If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?

@imheresamir imheresamir changed the title Updating the start script with platform_login for Openshift Implement E2E workflow for authenticator sidecars in OpenShift and Conjur Enterprise and follower in Jenkins Aug 18, 2021
@imheresamir imheresamir force-pushed the e2e-enterprise-followers-outside-openshift branch 5 times, most recently from 8b09bde to feae341 Compare August 19, 2021 06:07
@imheresamir imheresamir force-pushed the e2e-enterprise-followers-outside-openshift branch 10 times, most recently from c28f486 to 1bcdc72 Compare September 1, 2021 07:00
@imheresamir imheresamir force-pushed the e2e-enterprise-followers-outside-openshift branch 13 times, most recently from 3f38327 to dcda965 Compare September 6, 2021 00:23
@imheresamir imheresamir marked this pull request as ready for review September 6, 2021 04:42
@imheresamir imheresamir requested review from a team as code owners September 6, 2021 04:42
@imheresamir imheresamir force-pushed the e2e-enterprise-followers-outside-openshift branch 3 times, most recently from 21a34cf to d518c32 Compare September 6, 2021 04:53
@imheresamir imheresamir self-assigned this Sep 6, 2021
- Minor changes to get a new E2E flow working (authenticator sidecars in OpenShift and Conjur Enterprise and follower in Jenkins)
- Minor cleanups and deflaking
@imheresamir imheresamir force-pushed the e2e-enterprise-followers-outside-openshift branch from d518c32 to 768bfae Compare September 6, 2021 05:41
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two suggestions, two questions:

bin/test-workflow/stop Show resolved Hide resolved
bin/test-workflow/0_prep_env.sh Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered all my comments and questions! LGTM 😃

@imheresamir imheresamir merged commit 40b2f1d into master Sep 8, 2021
@imheresamir imheresamir deleted the e2e-enterprise-followers-outside-openshift branch September 8, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

There are end-to-end tests for Kubernetes sidecars with Conjur Enterprise and follower outside OpenShift
2 participants