chore: convert xhrs js to ts #30935
Open
chore: convert xhrs js to ts #30935
+77
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
convert-ts-2
|
| Run status |
|
| Run duration | 17m 41s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
13
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26478
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.83%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
165
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
jennifer-shehane
changed the title
| @@ -18,12 +19,43 @@ import type { CypressIncomingRequest } from '@packages/proxy' | |||
| import type { InterceptedRequest } from './intercepted-request' | |||
| import { caseInsensitiveGet, caseInsensitiveHas } from '../util' | |||
|
|
|||
| // TODO: move this into net-stubbing once cy.route is removed | |||
There was a problem hiding this comment.
There was a note about moving this into net-stubbing once cy.route was removed, so I did that 🤷🏻♀️
| import { expect } from 'chai' | ||
| import { join } from 'path' | ||
| import { readFileSync } from 'fs' | ||
|
|
||
| const imageBuffer = readFileSync(join(__dirname, '..', 'fixtures', 'cypress-logo.png')) | ||
|
|
||
| describe('net-stubbing util', () => { | ||
| describe('parseContentType', () => { |
There was a problem hiding this comment.
just moved the unit tests into net-stubbing with the function
jennifer-shehane
changed the title
AtofStryker
reviewed
Jan 24, 2025
| import type { CyHttpMessages } from '../external-types' | ||
| import { getEncoding } from 'istextorbinary' | ||
|
|
||
| const debug = Debug('cypress:net-stubbing:server:util') | ||
| const htmlLikeRe = /<.+>[\s\S]+<\/.+>/ | ||
|
|
||
| const isValidJSON = function (text) { |
There was a problem hiding this comment.
Suggested change
| const isValidJSON = function (text) { | |
| const isValidJSON = function (text: unknown) { |
| } | ||
|
|
||
| export function parseContentType (response?: string) { | ||
| const ret = (type) => { |
There was a problem hiding this comment.
Do we really get anything out of having this be its own function?
Suggested change
| const ret = (type) => { | |
| const ret = (type: string) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Converting server xhrs.js to typescript. There could be better types, but I didn't want to get too caught up in an area of code that I'm not super familiar with. Still attempting to have all references of
mimebe in TS files so we can upgrade the dep.Steps to test
ts lint/checks + tests pass
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?