fix: non-HTMLElement(s) fail during assertions #30947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/issue-30944
|
| Run status |
|
| Run duration | 17m 37s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26481
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.43%
|
|
|---|---|
|
Untested elements
|
192
|
|
Tested elements
|
164
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
| @@ -6,6 +6,7 @@ _Released 1/28/2025 (PENDING)_ | |||
| **Bugfixes:** | |||
|
|
|||
| - Fixed an issue where Cypress would incorrectly navigate to `about:blank` when test isolation was disabled and the last test would fail and then retry. Fixes [#28527](https://github.com/cypress-io/cypress/issues/28527). | |||
| - Fixed an issue where non-HTMLElement(s) may failing during assertions. Fixes [#30944](https://github.com/cypress-io/cypress/issues/30944) | |||
There was a problem hiding this comment.
Suggested change
| - Fixed an issue where non-HTMLElement(s) may failing during assertions. Fixes [#30944](https://github.com/cypress-io/cypress/issues/30944) | |
| - Fixed an issue where non-HTMLElement(s) may fail during assertions. Fixes [#30944](https://github.com/cypress-io/cypress/issues/30944) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In a previous PR the
transformlogic was updated to directly check$el[0].style.transform. However, it's possible that$el[0]is a standard Element and does not have thestyleproperty which leads to an error.Reverted the
transformlogic to what is was before but kept the defaulting tononeif the getPropertyValue('transform') returns an empty string.Steps to test
Assert on a non-HTMLElement and verifies it does not error.
How has the user experience changed?
No longer errors.
PR Tasks
cypress-documentation?type definitions?