Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin SQLAlchemy below 2 #251

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Pin SQLAlchemy below 2 #251

merged 2 commits into from
Feb 9, 2023

Conversation

bethac07
Copy link
Member

@bethac07 bethac07 commented Feb 6, 2023

modified from EmbeddedArtistry

Description

Resolves #250

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@bethac07 bethac07 requested a review from gwaybio February 6, 2023 23:54
@codecov-commenter
Copy link

Codecov Report

Merging #251 (5c15711) into master (afac3ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          53       53           
  Lines        2826     2826           
=======================================
  Hits         2705     2705           
  Misses        121      121           
Flag Coverage Δ
unittests 95.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

requirements.txt Outdated Show resolved Hide resolved
@gwaybio gwaybio mentioned this pull request Feb 7, 2023
@bethac07 bethac07 merged commit 7e57132 into master Feb 9, 2023
@bethac07 bethac07 deleted the issues/250 branch February 9, 2023 14:46
@gwaybio
Copy link
Member

gwaybio commented Feb 9, 2023

Thanks @bethac07 and @d33bs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlalchemy v2.0.0 bug causes cells.SingleCells to not work: ObjectNotExecutableError with read_sql
4 participants