Skip to content

Commit

Permalink
feat(props-must-be-readonly): disable rule to avoid issues
Browse files Browse the repository at this point in the history
  • Loading branch information
d0whc3r committed Sep 26, 2019
1 parent 86bc078 commit 66982b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ This rule catches Stencil Props marked as private or protected.

- [`@d0whc3r/stencil/props-must-be-readonly`](./docs/props-must-be-readonly.md)

> This rule is recommended to be "off" because it will trigger a bad autogenerated `components.d.ts` [more details here](https://github.com/ionic-team/stencil/issues/1896)
This rule catches Stencil Props marked as non readonly, excluding mutable ones.

- [`@d0whc3r/stencil/render-returns-host`](./docs/render-returns-host.md)
Expand Down Expand Up @@ -137,7 +139,7 @@ This rule catches Stencil Prop marked as mutable but not changing value in code.
"@d0whc3r/stencil/own-props-must-be-private": "error",
"@d0whc3r/stencil/prefer-vdom-listener": "error",
"@d0whc3r/stencil/props-must-be-public": "error",
"@d0whc3r/stencil/props-must-be-readonly": "error",
"@d0whc3r/stencil/props-must-be-readonly": "off",
"@d0whc3r/stencil/render-returns-host": "error",
"@d0whc3r/stencil/required-jsdoc": "error",
"@d0whc3r/stencil/reserved-member-names": "error",
Expand Down
2 changes: 1 addition & 1 deletion src/configs/recommended.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default {
'@d0whc3r/stencil/own-props-must-be-private': 'error',
'@d0whc3r/stencil/prefer-vdom-listener': 'error',
'@d0whc3r/stencil/props-must-be-public': 'error',
'@d0whc3r/stencil/props-must-be-readonly': 'error',
'@d0whc3r/stencil/props-must-be-readonly': 'off',
'@d0whc3r/stencil/render-returns-host': 'error',
'@d0whc3r/stencil/required-jsdoc': 'error',
'@d0whc3r/stencil/reserved-member-names': 'error',
Expand Down

0 comments on commit 66982b7

Please sign in to comment.