feat(headless/tab): orientation type

daangn · Jan 22, 2025 · 9b9a8c1 · 9b9a8c1
1 parent 727a8ab
commit 9b9a8c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-headless/tabs/src/types.ts b/packages/react-headless/tabs/src/types.ts
@@ -38,6 +38,8 @@ export interface UseTabsProps extends UseTabsStateProps, UseSwipeableStateProps
      */
     duration?: number;
   };
+
+  orientation?: "horizontal" | "vertical";
 }
 
 export interface TriggerProps {

diff --git a/packages/react-headless/tabs/src/useTabs.ts b/packages/react-headless/tabs/src/useTabs.ts
@@ -119,12 +119,10 @@ export function useTabs(props: UseTabsProps) {
     onValueChange: omitOnValueChange,
     isSwipeable = false,
     swipeConfig,
+    orientation = "horizontal",
     ...restProps
   } = props;
 
-  // TODO: orientation prop 추가
-  const orientation = "horizontal" as "horizontal" | "vertical";
-
   const updateIndicatorStyle = React.useCallback(() => {
     if (rootEl) {
       rootEl.style.setProperty("--seed-design-tabs-indicator-left", `${triggerSize.left}px`);
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         duration?: number;
       };
+      orientation?: "horizontal" | "vertical";
     }
     export interface TriggerProps {
@@ Expand Down @@