fix(core)!: delegate overrideInitialEvents to makeCoreStore (#445)

.changeset/funny-needles-design.md

@@ -0,0 +1,19 @@
+---
+"@stackflow/plugin-map-initial-activity": patch
+"@stackflow/plugin-google-analytics-4": patch
+"@stackflow/plugin-stack-depth-change": patch
+"@stackflow/plugin-renderer-basic": patch
+"@stackflow/plugin-history-sync": patch
+"@stackflow/plugin-renderer-web": patch
+"@stackflow/compat-await-push": patch
+"@stackflow/plugin-basic-ui": patch
+"@stackflow/plugin-devtools": patch
+"@stackflow/plugin-preload": patch
+"@stackflow/react": patch
+"@stackflow/link": patch
+"@stackflow/core": patch
+"@stackflow/demo": patch
+"@stackflow/docs": patch
+---
+
+fix(core)!: delegate overrideInitialEvents to makeCoreStore

.changeset/pre.json

@@ -0,0 +1,26 @@
+{
+  "mode": "exit",
+  "tag": "canary",
+  "initialVersions": {
+    "@stackflow/core": "1.0.9",
+    "@stackflow/demo": "1.2.19",
+    "@stackflow/docs": "1.2.20",
+    "@stackflow/compat-await-push": "1.1.6",
+    "@stackflow/link": "1.3.15",
+    "@stackflow/plugin-basic-ui": "1.5.1",
+    "@stackflow/plugin-devtools": "0.1.7",
+    "@stackflow/plugin-google-analytics-4": "1.1.8",
+    "@stackflow/plugin-history-sync": "1.3.17",
+    "@stackflow/plugin-map-initial-activity": "1.0.4",
+    "@stackflow/plugin-preload": "1.2.14",
+    "@stackflow/plugin-renderer-basic": "1.1.6",
+    "@stackflow/plugin-renderer-web": "1.1.6",
+    "@stackflow/plugin-stack-depth-change": "1.1.1",
+    "@stackflow/react": "1.1.6",
+    "@stackflow/esbuild-config": "1.0.1",
+    "@stackflow/eslint-config": "1.0.2"
+  },
+  "changesets": [
+    "red-lies-poke"
+  ]
+}

.changeset/red-lies-poke.md

@@ -0,0 +1,6 @@
+---
+"@stackflow/react": patch
+"@stackflow/core": patch
+---
+
+fix(core)!: delegate overrideInitialEvents to makeCoreStore

core/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @stackflow/core
 
+## 1.0.10-canary.0
+
+### Patch Changes
+
+- fix(core)!: delegate overrideInitialEvents to makeCoreStore
+
 ## 1.0.9
 
 ### Patch Changes

core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackflow/core",
-  "version": "1.0.9",
+  "version": "1.0.10-canary.0",
   "license": "MIT",
   "exports": {
     ".": {

core/src/makeCoreStore.ts

@@ -4,13 +4,13 @@ import isEqual from "react-fast-compare";
 
 import { aggregate } from "./aggregate";
 import type { Effect } from "./Effect";
-import type { DomainEvent } from "./event-types";
+import type { DomainEvent, PushedEvent, StepPushedEvent } from "./event-types";
 import type { BaseDomainEvent } from "./event-types/_base";
 import { makeEvent } from "./event-utils";
 import type { StackflowActions, StackflowPlugin } from "./interfaces";
 import { produceEffects } from "./produceEffects";
 import type { Stack } from "./Stack";
-import { once } from "./utils";
+import { divideBy, once } from "./utils";
 
 const SECOND = 1000;
 
@@ -19,26 +19,25 @@ const INTERVAL_MS = SECOND / 60;
 
 export type MakeCoreStoreOptions = {
   initialEvents: DomainEvent[];
+  initialContext?: any;
   plugins: StackflowPlugin[];
+  handlers?: {
+    onInitialActivityIgnored?: (
+      initialPushedEvents: (PushedEvent | StepPushedEvent)[],
+    ) => void;
+    onInitialActivityNotFound?: () => void;
+  };
 };
 
 export type CoreStore = {
   actions: StackflowActions;
   init: () => void;
   pullEvents: () => DomainEvent[];
   subscribe: (listener: () => void) => () => void;
+  pluginInstances: ReturnType<StackflowPlugin>[];
 };
 
 export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {
-  const events: {
-    value: DomainEvent[];
-  } = {
-    value: [...options.initialEvents],
-  };
-  const stack = {
-    value: aggregate(events.value, new Date().getTime()),
-  };
-
   const storeListeners: Array<() => void> = [];
 
   const defaultPlugin: StackflowPlugin = () => ({
@@ -53,6 +52,43 @@ export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {
     ...options.plugins.map((plugin) => plugin()),
   ];
 
+  const [initialPushedEventsByOption, initialRemainingEvents] = divideBy(
+    options.initialEvents,
+    (e) => e.name === "Pushed" || e.name === "StepPushed",
+  );
+
+  const initialPushedEvents = pluginInstances.reduce(
+    (initialEvents, pluginInstance) =>
+      pluginInstance.overrideInitialEvents?.({
+        initialEvents,
+        initialContext: options.initialContext ?? {},
+      }) ?? initialEvents,
+    initialPushedEventsByOption as (PushedEvent | StepPushedEvent)[],
+  );
+
+  const isInitialActivityIgnored =
+    initialPushedEvents.length > 0 &&
+    initialPushedEventsByOption.length > 0 &&
+    initialPushedEvents !== initialPushedEventsByOption;
+
+  if (isInitialActivityIgnored) {
+    options.handlers?.onInitialActivityIgnored?.(initialPushedEvents);
+  }
+
+  if (initialPushedEvents.length === 0) {
+    options.handlers?.onInitialActivityNotFound?.();
+  }
+
+  const events: {
+    value: DomainEvent[];
+  } = {
+    value: [...initialRemainingEvents, ...initialPushedEvents],
+  };
+
+  const stack = {
+    value: aggregate(events.value, new Date().getTime()),
+  };
+
   const setStackValue = (nextStackValue: Stack) => {
     const effects = produceEffects(stack.value, nextStackValue);
 
@@ -358,5 +394,6 @@ export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {
         }
       };
     },
+    pluginInstances,
   };
 }

core/src/utils/divideBy.spec.ts

@@ -0,0 +1,15 @@
+import { makeEvent } from "../event-utils";
+import { divideBy } from "./divideBy";
+
+test("divideBy", () => {
+  const firstEvent = makeEvent("Popped", {});
+  const secondEvent = makeEvent("StepPopped", {});
+  const thirdEvent = makeEvent("StepPopped", {});
+
+  expect(
+    divideBy(
+      [firstEvent, secondEvent, thirdEvent],
+      (e) => e.name === "StepPopped",
+    ),
+  ).toEqual([[secondEvent, thirdEvent], [firstEvent]]);
+});

core/src/utils/divideBy.ts

@@ -0,0 +1,17 @@
+export const divideBy = <T>(
+  arr: T[],
+  predicate: (t: T) => boolean,
+): [T[], T[]] => {
+  const satisfied: T[] = [];
+  const unsatisfied: T[] = [];
+
+  arr.forEach((element) => {
+    if (predicate(element)) {
+      satisfied.push(element);
+    } else {
+      unsatisfied.push(element);
+    }
+  });
+
+  return [satisfied, unsatisfied];
+};

core/src/utils/index.ts

@@ -1,4 +1,5 @@
 export * from "./compareBy";
+export * from "./divideBy";
 export * from "./findIndices";
 export * from "./id";
 export * from "./last";

demo/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @stackflow/demo
 
+## 1.2.20-canary.0
+
+### Patch Changes
+
+- Updated dependencies
+  - @stackflow/react@1.1.7-canary.0
+  - @stackflow/core@1.0.10-canary.0
+  - @stackflow/compat-await-push@1.1.7-canary.0
+  - @stackflow/link@1.3.16-canary.0
+  - @stackflow/plugin-basic-ui@1.5.2-canary.0
+  - @stackflow/plugin-history-sync@1.3.18-canary.0
+  - @stackflow/plugin-map-initial-activity@1.0.5-canary.0
+  - @stackflow/plugin-preload@1.2.15-canary.0
+  - @stackflow/plugin-renderer-basic@1.1.7-canary.0
+  - @stackflow/plugin-devtools@0.1.8-canary.0
+  - @stackflow/plugin-stack-depth-change@1.1.2-canary.0
+
 ## 1.2.19
 
 ### Patch Changes

demo/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackflow/demo",
-  "version": "1.2.19",
+  "version": "1.2.20-canary.0",
   "private": true,
   "license": "MIT",
   "exports": {
@@ -31,18 +31,18 @@
   "dependencies": {
     "@seed-design/design-token": "^1.0.0-alpha.0",
     "@seed-design/stylesheet": "^1.0.0-alpha.0",
-    "@stackflow/compat-await-push": "^1.1.6",
-    "@stackflow/core": "^1.0.9",
+    "@stackflow/compat-await-push": "^1.1.7-canary.0",
+    "@stackflow/core": "^1.0.10-canary.0",
     "@stackflow/eslint-config": "^1.0.2",
-    "@stackflow/link": "^1.3.15",
-    "@stackflow/plugin-basic-ui": "^1.4.2",
-    "@stackflow/plugin-devtools": "^0.1.7",
-    "@stackflow/plugin-history-sync": "^1.3.14",
-    "@stackflow/plugin-map-initial-activity": "^1.0.4",
-    "@stackflow/plugin-preload": "^1.2.14",
-    "@stackflow/plugin-renderer-basic": "^1.1.6",
-    "@stackflow/plugin-stack-depth-change": "^1.1.1",
-    "@stackflow/react": "^1.1.6",
+    "@stackflow/link": "^1.3.16-canary.0",
+    "@stackflow/plugin-basic-ui": "^1.5.2-canary.0",
+    "@stackflow/plugin-devtools": "^0.1.8-canary.0",
+    "@stackflow/plugin-history-sync": "^1.3.18-canary.0",
+    "@stackflow/plugin-map-initial-activity": "^1.0.5-canary.0",
+    "@stackflow/plugin-preload": "^1.2.15-canary.0",
+    "@stackflow/plugin-renderer-basic": "^1.1.7-canary.0",
+    "@stackflow/plugin-stack-depth-change": "^1.1.2-canary.0",
+    "@stackflow/react": "^1.1.7-canary.0",
     "@typescript-eslint/eslint-plugin": "^5.32.0",
     "@typescript-eslint/parser": "^5.20.0",
     "eslint": "^8.13.0",

docs/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @stackflow/docs
 
+## 1.2.21-canary.0
+
+### Patch Changes
+
+- Updated dependencies
+  - @stackflow/react@1.1.7-canary.0
+  - @stackflow/core@1.0.10-canary.0
+  - @stackflow/demo@1.2.20-canary.0
+  - @stackflow/plugin-basic-ui@1.5.2-canary.0
+  - @stackflow/plugin-history-sync@1.3.18-canary.0
+  - @stackflow/plugin-renderer-basic@1.1.7-canary.0
+
 ## 1.2.20
 
 ### Patch Changes

docs/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackflow/docs",
-  "version": "1.2.20",
+  "version": "1.2.21-canary.0",
   "private": true,
   "description": "Mobile-first stack navigator framework with Composable Plugin System",
   "license": "MIT",
@@ -11,13 +11,13 @@
   },
   "dependencies": {
     "@mdx-js/react": "^2.1.1",
-    "@stackflow/core": "^1.0.9",
-    "@stackflow/demo": "^1.2.19",
+    "@stackflow/core": "^1.0.10-canary.0",
+    "@stackflow/demo": "^1.2.20-canary.0",
     "@stackflow/eslint-config": "^1.0.2",
-    "@stackflow/plugin-basic-ui": "^1.4.2",
-    "@stackflow/plugin-history-sync": "^1.3.14",
-    "@stackflow/plugin-renderer-basic": "^1.1.6",
-    "@stackflow/react": "^1.1.6",
+    "@stackflow/plugin-basic-ui": "^1.5.2-canary.0",
+    "@stackflow/plugin-history-sync": "^1.3.18-canary.0",
+    "@stackflow/plugin-renderer-basic": "^1.1.7-canary.0",
+    "@stackflow/react": "^1.1.7-canary.0",
     "@types/react": "^18.0.15",
     "@typescript-eslint/eslint-plugin": "^5.32.0",
     "@typescript-eslint/parser": "^5.20.0",

extensions/compat-await-push/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @stackflow/compat-await-push
 
+## 1.1.7-canary.0
+
+### Patch Changes
+
+- Updated dependencies
+  - @stackflow/react@1.1.7-canary.0
+  - @stackflow/core@1.0.10-canary.0
+
 ## 1.1.6
 
 ### Patch Changes

extensions/compat-await-push/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stackflow/compat-await-push",
-  "version": "1.1.6",
+  "version": "1.1.7-canary.0",
   "license": "MIT",
   "exports": {
     ".": {
@@ -26,10 +26,10 @@
     "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
-    "@stackflow/core": "^1.0.9",
+    "@stackflow/core": "^1.0.10-canary.0",
     "@stackflow/esbuild-config": "^1.0.1",
     "@stackflow/eslint-config": "^1.0.2",
-    "@stackflow/react": "^1.1.6",
+    "@stackflow/react": "^1.1.7-canary.0",
     "@types/react": "^18.0.10",
     "@typescript-eslint/eslint-plugin": "^5.32.0",
     "@typescript-eslint/parser": "^5.20.0",
@@ -45,8 +45,8 @@
     "typescript": "^4.7.4"
   },
   "peerDependencies": {
-    "@stackflow/core": "^1.0.9",
-    "@stackflow/react": "^1.1.6",
+    "@stackflow/core": "^1.0.10-canary.0",
+    "@stackflow/react": "^1.1.7-canary.0",
     "@types/react": ">=16.8.0",
     "react": ">=16.8.0"
   },

extensions/link/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @stackflow/link
 
+## 1.3.16-canary.0
+
+### Patch Changes
+
+- Updated dependencies
+  - @stackflow/react@1.1.7-canary.0
+  - @stackflow/core@1.0.10-canary.0
+  - @stackflow/plugin-history-sync@1.3.18-canary.0
+  - @stackflow/plugin-preload@1.2.15-canary.0
+
 ## 1.3.15
 
 ### Patch Changes