-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies #471
chore: upgrade dependencies #471
Conversation
XiNiHa
commented
Jul 2, 2024
- ESLint is excluded from major bump since typescript-eslint v8 that supports ESLint v9 is still not released as stable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8fff184
to
8abc50d
Compare
8abc50d
to
9d5f935
Compare
Deployment failed with the following error:
|
9d5f935
to
631f8bb
Compare
631f8bb
to
be745df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @XiNiHa! .nvmrc
is currently set to version 16, but it seems like this part is out of sync. After discussing it internally, we decided that it would be better to delete .nvmrc
. Could you please apply that part?
be745df
to
3f8b4ea
Compare
Done! BTW, while removing the Node 16 requirement, I also updated CONTRIBUTING.md to state that only maintained Node versions are supported. Therefore it should be confirmed whether that matches what other maintainers are also thinking about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI: VSCode 1.19.1 is required for TypeScript Language Service |
@XiNiHa A simple version bump happened and it caused a conflict. 😅 Can you resolve this conflict? |
3f8b4ea
to
367a62e
Compare
@tonyfromundefined Done! |