Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(plugin-basic-ui): move top padding to margin #479

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

orionmiz
Copy link
Member

  • Substract the height of AppBar from AppScreen and apply top margin instead of top padding so that paper could have the visible height itself.

Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: da08b86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jul 22, 2024 2:44am

Copy link
Member

@tonyfromundefined tonyfromundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orionmiz orionmiz merged commit 3872e44 into main Jul 22, 2024
4 checks passed
@orionmiz orionmiz deleted the appscreen-padding-to-margin branch July 22, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants